diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2019-09-05 13:35:08 +0000 |
|---|---|---|
| committer | Filipa Lacerda <filipa@gitlab.com> | 2019-09-05 13:35:08 +0000 |
| commit | 2a1aeb33da89566891528c56c0e90a8698dffe5d (patch) | |
| tree | 69ae75149b39009c1f5c05afcffe9ba2b5c8fd83 | |
| parent | e1a1d5879844682435cde4443fd2f4255ad6c597 (diff) | |
| download | gitlab-ce-docs-fe-mr-review-docs.tar.gz | |
Apply suggestion to doc/development/fe_guide/development_process.mddocs-fe-mr-review-docs
| -rw-r--r-- | doc/development/fe_guide/development_process.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/development/fe_guide/development_process.md b/doc/development/fe_guide/development_process.md index 8654d23d998..179f5697104 100644 --- a/doc/development/fe_guide/development_process.md +++ b/doc/development/fe_guide/development_process.md @@ -72,7 +72,7 @@ With the purpose of being [respectful of others' time](https://about.gitlab.com/ - includes a changelog entry (when necessary) - Before assigning to a maintainer, assign to a reviewer. - If you assigned a merge request, or pinged someone directly, keep in mind that we work in different timezones and asynchronously, so be patient. Unless the merge request is urgent (like fixing a broken master), please don't DM or reassign the merge request before waiting for a 24-hour window. -- If you have a question regarding your Merge Request/Issue, please make it on the Merge Request/Issue. When we DM each other we no longer have a SSOT and [no one else is able to contribute][public-by-default] +- If you have a question regarding your merge request/issue, make it on the merge request/issue. When we DM each other, we no longer have a SSOT and [no one else is able to contribute](https://about.gitlab.com/handbook/values/#public-by-default). - When you have a big WIP merge request with many changes, you're adivsed to get the review started before adding/removing significant code. Make sure it is assigned well before the release cut-off, as the reviewer(s)/maintainer(s) would always prioritize reviewing finished MRs before WIP ones. - Make sure to remove the WIP title before the last round of review. |