summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2019-08-21 19:26:46 +0200
committerRémy Coutable <remy@rymai.me>2019-08-22 08:28:21 +0200
commitddb366196524f07f2b32a26885016ca0f1c30e1a (patch)
tree08b36253c285f4c6b00d62e85aedfb6f9c6ddd3f
parent1d5f5aa896a38104c375ac6ddd168d03d408f05e (diff)
downloadgitlab-ce-docs-improve-dnager-message-when-changelog-is-needed.tar.gz
Make it clear that it's ok to ignore Danger's 'no changelog' warningdocs-improve-dnager-message-when-changelog-is-needed
Signed-off-by: Rémy Coutable <remy@rymai.me>
-rw-r--r--danger/changelog/Dangerfile16
1 files changed, 9 insertions, 7 deletions
diff --git a/danger/changelog/Dangerfile b/danger/changelog/Dangerfile
index 63b2f6f5c5c..80f79ef139a 100644
--- a/danger/changelog/Dangerfile
+++ b/danger/changelog/Dangerfile
@@ -1,19 +1,21 @@
+# frozen_string_literal: true
# rubocop:disable Style/SignalException
require 'yaml'
-NO_CHANGELOG_LABELS = %w[backstage ci-build Documentation meta QA test].freeze
-SEE_DOC = "See [the documentation](https://docs.gitlab.com/ce/development/changelog.html).".freeze
-CREATE_CHANGELOG_MESSAGE = <<~MSG.freeze
-You can create one with:
+NO_CHANGELOG_LABELS = %w[backstage ci-build meta].freeze
+SEE_DOC = "See [the documentation](https://docs.gitlab.com/ce/development/changelog.html)."
+CREATE_CHANGELOG_MESSAGE = <<~MSG
+If you don't think your merge request [warrants a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry)
+(or if you already added one in another merge request), free to ignore this warning.
+
+Otherwise, you can create one with:
```
bin/changelog -m %<mr_iid>s "%<mr_title>s"
```
-If your merge request doesn't warrant a CHANGELOG entry,
-consider adding any of the %<labels>s labels.
-#{SEE_DOC}
+For your information, the following labels disable the CHANGELOG entry requirement check: %<labels>s.
MSG
def ee_changelog?(changelog_path)