summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHeinrich Lee Yu <heinrich@gitlab.com>2019-04-05 20:41:58 +0800
committerHeinrich Lee Yu <heinrich@gitlab.com>2019-04-05 20:41:58 +0800
commit84ec11131dee8a0137bc8d8b6ab9f6a1e452ed11 (patch)
tree5305e020767b3df50b4a8af17d4aff4c74dd19fb
parent186c1bdfddf4d8da00e7658ae9499b21eb1fb0e2 (diff)
downloadgitlab-ce-docs-update-rspec-set-usage.tar.gz
Add doc when rspec-set won't workdocs-update-rspec-set-usage
-rw-r--r--doc/development/testing_guide/best_practices.md6
1 files changed, 4 insertions, 2 deletions
diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md
index 7262c04d746..e41148360f2 100644
--- a/doc/development/testing_guide/best_practices.md
+++ b/doc/development/testing_guide/best_practices.md
@@ -216,8 +216,10 @@ project, one project will do for the entire file. This can be achieved by using
reloads or recreates the model, _only_ if needed. That is, when you changed
properties or destroyed the object.
-There is one gotcha; you can't reference a model defined in a `let` block in a
-`set` block.
+Note that you can't reference a model defined in a `let` block in a `set` block.
+
+Also, `set` is not supported in `:js` specs since those don't use transactions
+to clean up database state after each example.
### Time-sensitive tests