summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMayra Cabrera <mcabrera@gitlab.com>2019-09-02 13:56:42 -0500
committerMayra Cabrera <mcabrera@gitlab.com>2019-09-02 14:13:44 -0500
commit6b716389f99430d4a9631a09cbf87687fdc3a623 (patch)
tree3a7941f808b0704e35581c581aa43590eaaf5c88
parentd3076322f230cea1f60a7e27d7ae6e1fb770234a (diff)
downloadgitlab-ce-docs-updates-database-review-merge-request-author-responsibility.tar.gz
Updates the merge request author responsibilitydocs-updates-database-review-merge-request-author-responsibility
Indicate it's the author's responsibility to prepare the merge request for a database review
-rw-r--r--doc/development/database_review.md3
1 files changed, 2 insertions, 1 deletions
diff --git a/doc/development/database_review.md b/doc/development/database_review.md
index 367a481ee11..1847dcd6658 100644
--- a/doc/development/database_review.md
+++ b/doc/development/database_review.md
@@ -38,6 +38,7 @@ A Merge Request author's role is to:
- If database review is needed, add the ~database label.
- Use the [database changes](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.gitlab/merge_request_templates/Database%20changes.md)
merge request template, or include the appropriate items in the MR description.
+- [Prepare the merge request for a database review](#how-to-prepare-the-merge-request-for-a-database-review).
A database **reviewer**'s role is to:
@@ -68,7 +69,7 @@ make sure you have applied the ~database label and rerun the
`danger-review` CI job, or pick someone from the
[`@gl-database` team](https://gitlab.com/groups/gl-database/-/group_members).
-### How to prepare for speedy database reviews
+### How to prepare the merge request for a database review?
In order to make reviewing easier and therefore faster, please consider preparing a comment
and details for a database reviewer: