diff options
| author | Robert Speicher <rspeicher@gmail.com> | 2018-05-11 11:24:05 -0500 |
|---|---|---|
| committer | Robert Speicher <rspeicher@gmail.com> | 2018-05-11 11:24:05 -0500 |
| commit | 07adee306e960ce1151f6fc14914db3515e2724f (patch) | |
| tree | b1ab0d523dc15b541727d9717347fac246cde646 | |
| parent | 8284118f3619943976cff6c228de4e08e32abf73 (diff) | |
| download | gitlab-ce-docs/rs-code-review.tar.gz | |
Add Code Review documentation that maintainers also perform code reviewdocs/rs-code-review
| -rw-r--r-- | doc/development/code_review.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 53ddf3b062d..d03b7fa23ca 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -29,6 +29,10 @@ There are a few rules to get your merge request accepted: to ask one of the [Merge request coaches][team]. 1. The reviewer will assign the merge request to a maintainer once the reviewer is satisfied with the state of the merge request. +1. Keep in mind that maintainers are also going to perform a final code review. + The ideal scenario is that the reviewer has already addressed any concerns + the maintainer would have found, and the maintainer only has to perform the + merge, but be prepared for further review comments. For more guidance, see [CONTRIBUTING.md](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md). |