diff options
| author | Walmyr Lima <walmyr@gitlab.com> | 2019-06-12 10:58:35 +0200 |
|---|---|---|
| committer | Walmyr Lima <walmyr@gitlab.com> | 2019-06-12 10:59:49 +0200 |
| commit | c6f6bc69039e496146f618115f206c4d8782127e (patch) | |
| tree | 1308378eb48fa60fde83842fbac1016b71b96474 | |
| parent | a80a4959add91e3f9864051c886ff6e3f9f0b67f (diff) | |
| download | gitlab-ce-docs/suggest-views-methods-to-be-added-alphabetically.tar.gz | |
Remove standard suggestion on frontend filesdocs/suggest-views-methods-to-be-added-alphabetically
More details in the following discussion:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29499
| -rw-r--r-- | doc/development/testing_guide/end_to_end/quick_start_guide.md | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/doc/development/testing_guide/end_to_end/quick_start_guide.md b/doc/development/testing_guide/end_to_end/quick_start_guide.md index 618ab256e33..128d43dd5fb 100644 --- a/doc/development/testing_guide/end_to_end/quick_start_guide.md +++ b/doc/development/testing_guide/end_to_end/quick_start_guide.md @@ -547,11 +547,11 @@ Now let's change the view and the `dropdowns_helper` files to add the selectors In the [app/views/shared/issuable/_sidebar.html.haml](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/views/shared/issuable/_sidebar.html.haml) file, on [line 105 ](https://gitlab.com/gitlab-org/gitlab-ee/blob/84043fa72ca7f83ae9cde48ad670e6d5d16501a3/app/views/shared/issuable/_sidebar.html.haml#L105), add an extra class `qa-edit-link-labels`. -The code should look like this: `= link_to _('Edit'), '#', class: 'edit-link float-right js-sidebar-dropdown-toggle qa-edit-link-labels'`. +The code should look like this: `= link_to _('Edit'), '#', class: 'js-sidebar-dropdown-toggle edit-link float-right qa-edit-link-labels'`. In the same file, on [line 121](https://gitlab.com/gitlab-org/gitlab-ee/blob/84043fa72ca7f83ae9cde48ad670e6d5d16501a3/app/views/shared/issuable/_sidebar.html.haml#L121), add an extra class `.qa-dropdown-menu-labels`. -The code should look like this: `.dropdown-menu.dropdown-menu-labels.dropdown-menu-paging.dropdown-menu-selectable.dropdown-select.qa-dropdown-menu-labels`. +The code should look like this: `.dropdown-menu.dropdown-select.dropdown-menu-paging.dropdown-menu-labels.dropdown-menu-selectable.qa-dropdown-menu-labels`. In the [`dropdowns_helper.rb`](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/helpers/dropdowns_helper.rb) file, on [line 94](https://gitlab.com/gitlab-org/gitlab-ee/blob/99e51a374f2c20bee0989cac802e4b5621f72714/app/helpers/dropdowns_helper.rb#L94), add an extra class `qa-dropdown-input-field`. @@ -563,8 +563,6 @@ The code should look like this: `filter_output = search_field_tag search_id, nil > We did not define the `qa-labels-block` class in the `app/views/shared/issuable/_sidebar.html.haml` file because it was already there to be used. -> Notice that we also organize classes in the view files alphabetically to keep the standard. - #### Updates in the `QA::Page::Base` class The last thing that we have to do is to update `QA::Page::Base` class to add the `send_keys_to_element` method on it. |