summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZ.J. van de Weg <git@zjvandeweg.nl>2017-05-31 19:38:21 +0200
committerZ.J. van de Weg <git@zjvandeweg.nl>2017-05-31 19:38:21 +0200
commitc96beef17313d97fc9c3b060a1218e70b3d3fc1d (patch)
tree54ed6b4619340d9635b7dafbc3a5e3866a09d57d
parenta8901ce63dd302d008459321bd4a8007c7c8f7c7 (diff)
downloadgitlab-ce-docs/zj-let-vars.tar.gz
Remove requirement on let variables in specsdocs/zj-let-vars
-rw-r--r--doc/development/testing.md2
1 files changed, 0 insertions, 2 deletions
diff --git a/doc/development/testing.md b/doc/development/testing.md
index 6d8b846d27f..47df081ebc3 100644
--- a/doc/development/testing.md
+++ b/doc/development/testing.md
@@ -216,8 +216,6 @@ so we need to set some guidelines for their use going forward:
- `let` variables are preferable to instance variables. Local variables are
preferable to `let` variables.
- Use `let` to reduce duplication throughout an entire spec file.
-- Don't use `let` to define variables used by a single test; define them as
- local variables inside the test's `it` block.
- Don't define a `let` variable inside the top-level `describe` block that's
only used in a more deeply-nested `context` or `describe` block. Keep the
definition as close as possible to where it's used.