summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2016-04-20 14:41:50 +0200
committerRémy Coutable <remy@rymai.me>2016-04-20 14:46:31 +0200
commitdd06238bc3cb2df851a01e52d03ea5a4a034ced7 (patch)
tree28ce3bc30a318fa1300a8c52347d5d7bde694a11
parent76ba66cbe755e90645bd3741942bb2b2a5b172c1 (diff)
downloadgitlab-ce-due-date-frontend.tar.gz
Move Issue scopes from Issuable to Issue modeldue-date-frontend
Signed-off-by: Rémy Coutable <remy@rymai.me>
-rw-r--r--app/finders/issuable_finder.rb40
-rw-r--r--app/models/concerns/issuable.rb4
-rw-r--r--app/models/issue.rb4
3 files changed, 24 insertions, 24 deletions
diff --git a/app/finders/issuable_finder.rb b/app/finders/issuable_finder.rb
index 80f28de2296..ee61cb9c009 100644
--- a/app/finders/issuable_finder.rb
+++ b/app/finders/issuable_finder.rb
@@ -113,26 +113,6 @@ class IssuableFinder
end
end
- def due_date?
- params[:due_date].present? && klass.column_names.include?('due_date')
- end
-
- def filter_by_no_due_date?
- due_date? && params[:due_date] == Issue::NoDueDate.name
- end
-
- def filter_by_overdue?
- due_date? && params[:due_date] == Issue::Overdue.name
- end
-
- def filter_by_due_this_week?
- due_date? && params[:due_date] == Issue::DueThisWeek.name
- end
-
- def filter_by_due_this_month?
- due_date? && params[:due_date] == Issue::DueThisMonth.name
- end
-
def labels?
params[:label_name].present?
end
@@ -318,6 +298,26 @@ class IssuableFinder
items
end
+ def filter_by_no_due_date?
+ due_date? && params[:due_date] == Issue::NoDueDate.name
+ end
+
+ def filter_by_overdue?
+ due_date? && params[:due_date] == Issue::Overdue.name
+ end
+
+ def filter_by_due_this_week?
+ due_date? && params[:due_date] == Issue::DueThisWeek.name
+ end
+
+ def filter_by_due_this_month?
+ due_date? && params[:due_date] == Issue::DueThisMonth.name
+ end
+
+ def due_date?
+ params[:due_date].present? && klass.column_names.include?('due_date')
+ end
+
def label_names
params[:label_name].split(',')
end
diff --git a/app/models/concerns/issuable.rb b/app/models/concerns/issuable.rb
index 7c2a92fa86a..afa2ca039ae 100644
--- a/app/models/concerns/issuable.rb
+++ b/app/models/concerns/issuable.rb
@@ -40,10 +40,6 @@ module Issuable
scope :with_label, ->(title) { joins(:labels).where(labels: { title: title }) }
scope :without_label, -> { joins("LEFT OUTER JOIN label_links ON label_links.target_type = '#{name}' AND label_links.target_id = #{table_name}.id").where(label_links: { id: nil }) }
- scope :without_due_date, -> { where('issues.due_date IS NULL') }
- scope :due_before, ->(date) { where('issues.due_date < ?', date) }
- scope :due_between, ->(from_date, to_date) { where('issues.due_date >= ?', from_date).where('issues.due_date <= ?', to_date) }
-
scope :join_project, -> { joins(:project) }
scope :references_project, -> { references(:project) }
scope :non_archived, -> { join_project.where(projects: { archived: false }) }
diff --git a/app/models/issue.rb b/app/models/issue.rb
index 9a382fcda8d..ea1bfb776ee 100644
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -46,6 +46,10 @@ class Issue < ActiveRecord::Base
scope :open_for, ->(user) { opened.assigned_to(user) }
scope :in_projects, ->(project_ids) { where(project_id: project_ids) }
+ scope :without_due_date, -> { where(due_date: nil) }
+ scope :due_before, ->(date) { where('issues.due_date < ?', date) }
+ scope :due_between, ->(from_date, to_date) { where('issues.due_date >= ?', from_date).where('issues.due_date <= ?', to_date) }
+
scope :order_due_date_asc, -> { reorder('issues.due_date IS NULL, issues.due_date ASC') }
scope :order_due_date_desc, -> { reorder('issues.due_date IS NULL, issues.due_date DESC') }