summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2017-07-24 19:26:15 +0300
committerDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2017-07-24 19:26:15 +0300
commit3a0b9e06e1dd5f6141a6f04dd2b39dbb803c07f1 (patch)
tree3db369acec13cf268553d051614ca95dbfc7c69d
parentcc577b89706686063d4ff0d86a11c63b6570231c (diff)
downloadgitlab-ce-dz-update-shoulda.tar.gz
Adjust tests to work with latest shoulda gemdz-update-shoulda
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-rw-r--r--spec/models/list_spec.rb6
-rw-r--r--spec/models/notification_setting_spec.rb4
-rw-r--r--spec/models/user_spec.rb4
3 files changed, 6 insertions, 8 deletions
diff --git a/spec/models/list_spec.rb b/spec/models/list_spec.rb
index db2c2619968..a6cc01bea5f 100644
--- a/spec/models/list_spec.rb
+++ b/spec/models/list_spec.rb
@@ -13,12 +13,6 @@ describe List do
it { is_expected.to validate_presence_of(:position) }
it { is_expected.to validate_numericality_of(:position).only_integer.is_greater_than_or_equal_to(0) }
- it 'validates uniqueness of label scoped to board_id' do
- create(:list)
-
- expect(subject).to validate_uniqueness_of(:label_id).scoped_to(:board_id)
- end
-
context 'when list_type is set to closed' do
subject { described_class.new(list_type: :closed) }
diff --git a/spec/models/notification_setting_spec.rb b/spec/models/notification_setting_spec.rb
index 74fa1c1f926..76a7b07949f 100644
--- a/spec/models/notification_setting_spec.rb
+++ b/spec/models/notification_setting_spec.rb
@@ -13,7 +13,9 @@ RSpec.describe NotificationSetting, type: :model do
it { is_expected.to validate_presence_of(:level) }
describe 'user_id' do
- before { subject.user = create(:user) }
+ before do
+ subject.user = create(:user)
+ end
it { is_expected.to validate_uniqueness_of(:user_id).scoped_to([:source_type, :source_id]).with_message(/already exists in source/) }
end
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
index a1d6d7e6e0b..20bdb7e37da 100644
--- a/spec/models/user_spec.rb
+++ b/spec/models/user_spec.rb
@@ -114,7 +114,9 @@ describe User, models: true do
end
it 'validates uniqueness' do
- expect(subject).to validate_uniqueness_of(:username).case_insensitive
+ user = build(:user)
+
+ expect(user).to validate_uniqueness_of(:username).case_insensitive
end
end