summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEzekiel Kigbo <ekigbo@gitlab.com>2019-07-23 17:23:59 +1000
committerEzekiel Kigbo <ekigbo@gitlab.com>2019-07-23 17:57:56 +1000
commita27d1cc908b7e992bb68ff0927be853971ccde83 (patch)
tree252bd23e6c9da5725eba4827d444078b0437b1b0
parent7c3c53c618af30d2907175a49d9ce17d53b6fc0e (diff)
downloadgitlab-ce-ek-explore-ca-add-stage-form.tar.gz
Load form on triggerek-explore-ca-add-stage-form
-rw-r--r--app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js16
1 files changed, 14 insertions, 2 deletions
diff --git a/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js b/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js
index 299d36e2ae2..ea2cc7c2b56 100644
--- a/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js
+++ b/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js
@@ -66,8 +66,6 @@ export default () => {
// variable itself can be completely removed.
// Follow up issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/64490
if (cycleAnalyticsEl.dataset.requestPath) this.fetchCycleAnalyticsData();
- // TODO: remove
- this.addStageForm = true;
},
methods: {
handleError() {
@@ -144,6 +142,20 @@ export default () => {
this.isOverviewDialogDismissed = true;
Cookies.set(OVERVIEW_DIALOG_COOKIE, '1', { expires: 365 });
},
+ showAddStageForm() {
+ console.log('cycle_analytics_bundle::showAddStageForm', this);
+ // TODO: should these eventually be moved to actions for a vuex store
+ this.isLoadingStage = true;
+
+ // TODO: do async-y stuff if we need it?
+ // Maybe loading the data, but most likely we can bootstrap that in the form as props
+
+ // TODO: perhaps could be something more like this.activeStage('stage-name') ie loading, empty, custom form etc
+
+ // Should eventually be actions emitted to the vuex store
+ this.addStageForm = true;
+ this.isLoadingStage = false;
+ },
},
});
};