Improve clarity and precision of specsembedded-metrics-be-2

2 files changed, 7 insertions, 5 deletions

diff --git a/spec/lib/banzai/filter/inline_metrics_filter_spec.rb b/spec/lib/banzai/filter/inline_metrics_filter_spec.rb
index 91ed6423b48..772c94e3180 100644
--- a/spec/lib/banzai/filter/inline_metrics_filter_spec.rb
+++ b/spec/lib/banzai/filter/inline_metrics_filter_spec.rb
@@ -17,17 +17,19 @@ describe Banzai::Filter::InlineMetricsFilter do
   end
 
   context 'when the document has a metrics dashboard link' do
-    let(:url) { urls.metrics_namespace_project_environment_url('foo', 'bar', 12) }
+    let(:params) { ['foo', 'bar', 12] }
+    let(:url) { urls.metrics_namespace_project_environment_url(*params) }
 
     it 'leaves the original link unchanged' do
       expect(doc.at_css('a').to_s).to eq input
     end
 
-    it 'appends a metrics charts placeholder after metrics links' do
+    it 'appends a metrics charts placeholder with dashboard url after metrics links' do
       node = doc.at_css('.js-render-metrics')
-
       expect(node).to be_present
-      expect(node.attribute('data-dashboard-url').to_s).to be_present
+
+      dashboard_url = urls.metrics_dashboard_namespace_project_environment_url(*params, embedded: true)
+      expect(node.attribute('data-dashboard-url').to_s).to eq dashboard_url
     end
 
     context 'when the metrics dashboard link is part of a paragraph' do
diff --git a/spec/lib/banzai/filter/inline_metrics_redactor_filter_spec.rb b/spec/lib/banzai/filter/inline_metrics_redactor_filter_spec.rb
index 527b3922f05..da69febc609 100644
--- a/spec/lib/banzai/filter/inline_metrics_redactor_filter_spec.rb
+++ b/spec/lib/banzai/filter/inline_metrics_redactor_filter_spec.rb
@@ -32,7 +32,7 @@ describe Banzai::Filter::InlineMetricsRedactorFilter do
 
     context 'no user is logged in' do
       it 'redacts the placeholder' do
-        expect(doc.to_s).to eq ''
+        expect(doc.to_s).to be_empty
       end
     end