diff options
author | Filipa Lacerda <filipa@gitlab.com> | 2017-04-27 09:58:54 +0100 |
---|---|---|
committer | Filipa Lacerda <filipa@gitlab.com> | 2017-04-27 09:58:54 +0100 |
commit | 9903febe6a831fff23cd54cd9847e9eb3816c140 (patch) | |
tree | 4ccfc06c7a9019a6f8f1c79ea1f1668837a047fe | |
parent | c199926b7656afaf0f65698d803a8c92effcbdde (diff) | |
download | gitlab-ce-environments-vue-5.tar.gz |
Changes after reviewenvironments-vue-5
3 files changed, 12 insertions, 14 deletions
diff --git a/app/assets/javascripts/environments/components/environment.vue b/app/assets/javascripts/environments/components/environment.vue index 9e4c358cb8e..f319d6ca0c8 100644 --- a/app/assets/javascripts/environments/components/environment.vue +++ b/app/assets/javascripts/environments/components/environment.vue @@ -157,7 +157,7 @@ export default { </span> </a> </li> - <li :class="{ 'active' : scope === 'stopped' }"> + <li :class="{ active : scope === 'stopped' }"> <a :href="projectStoppedEnvironmentsPath"> Stopped <span class="badge js-stopped-environments-count"> @@ -221,7 +221,8 @@ export default { :is-loading-folder-content="isLoadingFolderContent" /> </div> - <table-pagination v-if="state.paginationInformation && state.paginationInformation.totalPages > 1" + <table-pagination + v-if="state.paginationInformation && state.paginationInformation.totalPages > 1" :change="changePage" :pageInfo="state.paginationInformation" /> </div> diff --git a/app/assets/javascripts/environments/folder/environments_folder_bundle.js b/app/assets/javascripts/environments/folder/environments_folder_bundle.js index 8b9c477e1a8..9add8c3d721 100644 --- a/app/assets/javascripts/environments/folder/environments_folder_bundle.js +++ b/app/assets/javascripts/environments/folder/environments_folder_bundle.js @@ -1,13 +1,10 @@ import Vue from 'vue'; import EnvironmentsFolderComponent from './environments_folder_view.vue'; -document.addEventListener('DOMContentLoaded', () => { - // eslint-disable-next-line no-new - new Vue({ - el: '#environments-folder-list-view', - components: { - 'environments-folder-app': EnvironmentsFolderComponent, - }, - render: createElement => createElement('environments-folder-app'), - }); -}); +document.addEventListener('DOMContentLoaded', () => new Vue({ + el: '#environments-folder-list-view', + components: { + 'environments-folder-app': EnvironmentsFolderComponent, + }, + render: createElement => createElement('environments-folder-app'), +})); diff --git a/app/assets/javascripts/environments/folder/environments_folder_view.vue b/app/assets/javascripts/environments/folder/environments_folder_view.vue index ac973924976..d27b2acfcdf 100644 --- a/app/assets/javascripts/environments/folder/environments_folder_view.vue +++ b/app/assets/javascripts/environments/folder/environments_folder_view.vue @@ -129,7 +129,7 @@ export default { </h4> <ul class="nav-links"> - <li :class="{ 'active': scope === null || scope === 'available' }"> + <li :class="{ active: scope === null || scope === 'available' }"> <a :href="availablePath" class="js-available-environments-folder-tab"> @@ -139,7 +139,7 @@ export default { </span> </a> </li> - <li :class="{ 'active' : scope === 'stopped' }"> + <li :class="{ active : scope === 'stopped' }"> <a :href="stoppedPath" class="js-stopped-environments-folder-tab"> |