diff options
author | Lin Jen-Shin <godfat@godfat.org> | 2016-11-23 19:43:56 +0800 |
---|---|---|
committer | Lin Jen-Shin <godfat@godfat.org> | 2016-11-23 19:43:56 +0800 |
commit | bd3a544ab0417b758cf5e8e5bcd4ae9c0fed1bae (patch) | |
tree | 5051682df737a82ea1dca0b2bb5feb901fcf83cd | |
parent | cc43c9acc29117cd9ec3c25805e6c5ea874e5969 (diff) | |
download | gitlab-ce-fix-cancelling-pipelines.tar.gz |
Wrap against 80 chars and rename failed_or_canceledfix-cancelling-pipelines
to better reflect the status. Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7508#note_18858398
-rw-r--r-- | app/models/ci/pipeline.rb | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/app/models/ci/pipeline.rb b/app/models/ci/pipeline.rb index c0f2c8ba787..4294a10e9e3 100644 --- a/app/models/ci/pipeline.rb +++ b/app/models/ci/pipeline.rb @@ -169,17 +169,19 @@ module Ci end def cancel_running - Gitlab::OptimisticLocking.retry_lock(statuses.cancelable) do |cancelable| - cancelable.each(&:cancel) - end + Gitlab::OptimisticLocking.retry_lock( + statuses.cancelable) do |cancelable| + cancelable.each(&:cancel) + end end def retry_failed(user) - Gitlab::OptimisticLocking.retry_lock(builds.latest.failed_or_canceled) do |failed| - failed.select(&:retryable?).each do |build| - Ci::Build.retry(build, user) + Gitlab::OptimisticLocking.retry_lock( + builds.latest.failed_or_canceled) do |failed_or_canceled| + failed_or_canceled.select(&:retryable?).each do |build| + Ci::Build.retry(build, user) + end end - end end def mark_as_processable_after_stage(stage_idx) |