diff options
author | Clement Ho <ClemMakesApps@gmail.com> | 2017-12-18 18:16:15 -0600 |
---|---|---|
committer | Clement Ho <ClemMakesApps@gmail.com> | 2017-12-18 18:16:15 -0600 |
commit | e4786a857688d9e37c2d1630459bc8cf2c986af4 (patch) | |
tree | fa4b5fc731c75d318094daf3fe930d580fb1f25f | |
parent | 4860f586533a1d2dc793bcaf601ef6478add66da (diff) | |
download | gitlab-ce-fix-docs-help-shortcut.tar.gz |
Add bundle and specfix-docs-help-shortcut
-rw-r--r-- | app/assets/javascripts/docs/docs_bundle.js | 13 | ||||
-rw-r--r-- | spec/features/help_pages_spec.rb | 18 |
2 files changed, 31 insertions, 0 deletions
diff --git a/app/assets/javascripts/docs/docs_bundle.js b/app/assets/javascripts/docs/docs_bundle.js new file mode 100644 index 00000000000..a32bd6d0fc7 --- /dev/null +++ b/app/assets/javascripts/docs/docs_bundle.js @@ -0,0 +1,13 @@ +import Mousetrap from 'mousetrap'; + +function addMousetrapClick(el, key) { + el.addEventListener('click', () => Mousetrap.trigger(key)); +} + +function domContentLoaded() { + addMousetrapClick(document.querySelector('.js-trigger-shortcut'), '?'); + addMousetrapClick(document.querySelector('.js-trigger-search-bar'), 's'); +} + +document.addEventListener('DOMContentLoaded', domContentLoaded); + diff --git a/spec/features/help_pages_spec.rb b/spec/features/help_pages_spec.rb index ab896a310be..0d04ed612c2 100644 --- a/spec/features/help_pages_spec.rb +++ b/spec/features/help_pages_spec.rb @@ -32,6 +32,24 @@ describe 'Help Pages' do it_behaves_like 'help page', prefix: '/gitlab' end + + context 'quick link shortcuts', :js do + before do + visit help_path + end + + it 'focuses search bar' do + find('.js-trigger-search-bar').click + + expect(page).to have_selector('#search:focus') + end + + it 'opens shortcuts help dialog' do + find('.js-trigger-shortcut').click + + expect(page).to have_selector('#modal-shortcuts') + end + end end context 'in a production environment with version check enabled', :js do |