summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBalasankar "Balu" C <balasankar@gitlab.com>2019-08-13 11:12:26 +0530
committerBalasankar "Balu" C <balasankar@gitlab.com>2019-08-13 14:28:54 +0530
commit9ab5346eeb7c1891a6828386334fa3e6b853a931 (patch)
tree1f24b0f51ace46efc8e3d325517bb1c6d308627b
parent943dbeffab397e20a748ff4f91922b79a7f29598 (diff)
downloadgitlab-ce-fix-filename-length.tar.gz
Ensure changelog filenames are less than 99 characters longfix-filename-length
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
-rwxr-xr-xbin/changelog2
-rw-r--r--spec/bin/changelog_spec.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/bin/changelog b/bin/changelog
index 328d9495b96..ec068d06507 100755
--- a/bin/changelog
+++ b/bin/changelog
@@ -23,7 +23,7 @@ module ChangelogHelpers
Abort = Class.new(StandardError)
Done = Class.new(StandardError)
- MAX_FILENAME_LENGTH = 140 # ecryptfs has a limit of 140 characters
+ MAX_FILENAME_LENGTH = 99 # GNU tar has a 99 character limit
def capture_stdout(cmd)
output = IO.popen(cmd, &:read)
diff --git a/spec/bin/changelog_spec.rb b/spec/bin/changelog_spec.rb
index 84bbe0525e5..c3a5abf2b7a 100644
--- a/spec/bin/changelog_spec.rb
+++ b/spec/bin/changelog_spec.rb
@@ -15,7 +15,7 @@ describe 'bin/changelog' do
allow(entry).to receive(:branch_name).and_return('long-branch-' * 100)
file_path = entry.send(:file_path)
- expect(file_path.length).to eq(140)
+ expect(file_path.length).to eq(99)
end
end