diff options
| author | Phil Hughes <me@iamphill.com> | 2017-08-03 10:20:02 +0100 |
|---|---|---|
| committer | Phil Hughes <me@iamphill.com> | 2017-08-03 12:08:10 +0100 |
| commit | 42feb55f20a6d2bab2d07f2f32bccb1b4ae28ba8 (patch) | |
| tree | f61f9690e3b31e18d05d3116701fe4f5bcbde848 | |
| parent | 88958e5a9cd364ae36f3d2837982cedb9239c3bc (diff) | |
| download | gitlab-ce-fix-oauth-checkboxes.tar.gz | |
Fixed sign-in restrictions buttons not toggling active statefix-oauth-checkboxes
Closes #35882
| -rw-r--r-- | app/assets/javascripts/commons/bootstrap.js | 1 | ||||
| -rw-r--r-- | changelogs/unreleased/fix-oauth-checkboxes.yml | 4 | ||||
| -rw-r--r-- | spec/features/admin/admin_settings_spec.rb | 8 |
3 files changed, 13 insertions, 0 deletions
diff --git a/app/assets/javascripts/commons/bootstrap.js b/app/assets/javascripts/commons/bootstrap.js index 510bedbf641..389587a2596 100644 --- a/app/assets/javascripts/commons/bootstrap.js +++ b/app/assets/javascripts/commons/bootstrap.js @@ -9,6 +9,7 @@ import 'bootstrap-sass/assets/javascripts/bootstrap/tab'; import 'bootstrap-sass/assets/javascripts/bootstrap/transition'; import 'bootstrap-sass/assets/javascripts/bootstrap/tooltip'; import 'bootstrap-sass/assets/javascripts/bootstrap/popover'; +import 'bootstrap-sass/assets/javascripts/bootstrap/button'; // custom jQuery functions $.fn.extend({ diff --git a/changelogs/unreleased/fix-oauth-checkboxes.yml b/changelogs/unreleased/fix-oauth-checkboxes.yml new file mode 100644 index 00000000000..2839ccc42cb --- /dev/null +++ b/changelogs/unreleased/fix-oauth-checkboxes.yml @@ -0,0 +1,4 @@ +--- +title: Fixed sign-in restrictions buttons not toggling active state +merge_request: +author: diff --git a/spec/features/admin/admin_settings_spec.rb b/spec/features/admin/admin_settings_spec.rb index c1eced417cf..c9591a7d854 100644 --- a/spec/features/admin/admin_settings_spec.rb +++ b/spec/features/admin/admin_settings_spec.rb @@ -69,6 +69,14 @@ feature 'Admin updates settings' do expect(find('#service_push_channel').value).to eq '#test_channel' end + context 'sign-in restrictions', :js do + it 'de-activates oauth sign-in source' do + find('.btn', text: 'GitLab.com').click + + expect(find('.btn', text: 'GitLab.com')).not_to have_css('.active') + end + end + def check_all_events page.check('Active') page.check('Push') |