diff options
| author | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-07-19 23:23:36 +0200 |
|---|---|---|
| committer | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-07-20 23:34:16 +0200 |
| commit | 7e2f916cd0364923e02f42f459204ddabcb05963 (patch) | |
| tree | a527c7b79be8b86e850679876227f5544bd492af | |
| parent | 3036f9ae893f14ca3d5bc9aa9b6d7f03842d1e5d (diff) | |
| download | gitlab-ce-fix-params-name-bug.tar.gz | |
Add additional specsfix-params-name-bug
Fix params name
| -rw-r--r-- | app/controllers/projects/cycle_analytics/events_controller.rb | 2 | ||||
| -rw-r--r-- | spec/controllers/projects/cycle_analytics/events_controller_spec.rb | 10 |
2 files changed, 10 insertions, 2 deletions
diff --git a/app/controllers/projects/cycle_analytics/events_controller.rb b/app/controllers/projects/cycle_analytics/events_controller.rb index 740dc8078ba..926592b9681 100644 --- a/app/controllers/projects/cycle_analytics/events_controller.rb +++ b/app/controllers/projects/cycle_analytics/events_controller.rb @@ -23,7 +23,7 @@ module Projects end def test - options(events_params)[:branch] = events_params[:branch_name] + options(cycle_analytics_params)[:branch] = cycle_analytics_params[:branch_name] render_events(cycle_analytics[:test].events) end diff --git a/spec/controllers/projects/cycle_analytics/events_controller_spec.rb b/spec/controllers/projects/cycle_analytics/events_controller_spec.rb index f863e96dcfc..8fc3ae0aa32 100644 --- a/spec/controllers/projects/cycle_analytics/events_controller_spec.rb +++ b/spec/controllers/projects/cycle_analytics/events_controller_spec.rb @@ -33,8 +33,16 @@ describe Projects::CycleAnalytics::EventsController do get_issue expect(response).to be_success + end + + it 'contains event detais' do + get_issue + + events = JSON.parse(response.body)['events'] - expect(JSON.parse(response.body)['events']).not_to be_empty + expect(events).not_to be_empty + expect(events.first).to include('title', 'author', 'iid', 'total_time', 'created_at', 'url') + expect(events.first['title']).to eq(issue.title) end context 'with data older than start date' do |