summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean McGivern <sean@gitlab.com>2019-09-03 13:13:36 +0100
committerSean McGivern <sean@gitlab.com>2019-09-03 13:13:36 +0100
commit18018bcd41c0a08c2a506733241206a0e0a9b7e5 (patch)
tree8794becf0dc3a58b93ef33205228df387356764d
parent937b2027041e6d1f2aad1b62af107c0768f4a6f2 (diff)
downloadgitlab-ce-fix-performance-bar-thresholds.tar.gz
Fix performance bar thresholdsfix-performance-bar-thresholds
These were written in seconds but are supposed to be in milliseconds. The total Gitaly time was wrong for the same reason.
-rw-r--r--lib/peek/views/active_record.rb8
-rw-r--r--lib/peek/views/gitaly.rb10
2 files changed, 9 insertions, 9 deletions
diff --git a/lib/peek/views/active_record.rb b/lib/peek/views/active_record.rb
index bbc9f11e90f..1bb3ddb964a 100644
--- a/lib/peek/views/active_record.rb
+++ b/lib/peek/views/active_record.rb
@@ -5,15 +5,15 @@ module Peek
class ActiveRecord < DetailedView
DEFAULT_THRESHOLDS = {
calls: 100,
- duration: 3,
- individual_call: 1
+ duration: 3000,
+ individual_call: 1000
}.freeze
THRESHOLDS = {
production: {
calls: 100,
- duration: 15,
- individual_call: 5
+ duration: 15000,
+ individual_call: 5000
}
}.freeze
diff --git a/lib/peek/views/gitaly.rb b/lib/peek/views/gitaly.rb
index f669feae254..7dc00b16cc0 100644
--- a/lib/peek/views/gitaly.rb
+++ b/lib/peek/views/gitaly.rb
@@ -5,15 +5,15 @@ module Peek
class Gitaly < DetailedView
DEFAULT_THRESHOLDS = {
calls: 30,
- duration: 1,
- individual_call: 0.5
+ duration: 1000,
+ individual_call: 500
}.freeze
THRESHOLDS = {
production: {
calls: 30,
- duration: 1,
- individual_call: 0.5
+ duration: 1000,
+ individual_call: 500
}
}.freeze
@@ -24,7 +24,7 @@ module Peek
private
def duration
- ::Gitlab::GitalyClient.query_time
+ ::Gitlab::GitalyClient.query_time * 1000
end
def calls