summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouglas Barbosa Alexandre <dbalexandre@gmail.com>2016-01-20 16:55:47 -0200
committerDouglas Barbosa Alexandre <dbalexandre@gmail.com>2016-01-20 16:55:47 -0200
commitfd5fdfd69ef13d5a61ba250bcf83776e6ae389ba (patch)
treed6a7a738eb9243d2c75b694a939a071089bb65c3
parent481644ca7c9f763d4646ad557cc3bcf8f4f71816 (diff)
downloadgitlab-ce-fix-project-creation.tar.gz
Creator should be added as a master of the project on creationfix-project-creation
This also enable a project creator to add themselves as a master of the project.
-rw-r--r--app/models/member.rb9
-rw-r--r--app/services/projects/create_service.rb2
2 files changed, 9 insertions, 2 deletions
diff --git a/app/models/member.rb b/app/models/member.rb
index 28aee2e3799..c1138b80b4a 100644
--- a/app/models/member.rb
+++ b/app/models/member.rb
@@ -91,7 +91,9 @@ class Member < ActiveRecord::Base
member.invite_email = user
end
- if can_update_member?(current_user, member)
+ can_update = can_update_member?(current_user, member) || project_creator?(member, access_level)
+
+ if can_update
member.created_by ||= current_user
member.access_level = access_level
@@ -107,6 +109,11 @@ class Member < ActiveRecord::Base
current_user.can?(:update_group_member, member) ||
current_user.can?(:update_project_member, member)
end
+
+ def project_creator?(member, access_level)
+ member.new_record? && member.owner? &&
+ access_level.to_i == ProjectMember::MASTER
+ end
end
def invite?
diff --git a/app/services/projects/create_service.rb b/app/services/projects/create_service.rb
index c94d7ab710f..a6820183bee 100644
--- a/app/services/projects/create_service.rb
+++ b/app/services/projects/create_service.rb
@@ -95,7 +95,7 @@ module Projects
system_hook_service.execute_hooks_for(@project, :create)
unless @project.group
- @project.team << [current_user, :master]
+ @project.team << [current_user, :master, current_user]
end
@project.import_start if @project.import?