diff options
author | Sean McGivern <sean@gitlab.com> | 2017-07-07 10:57:34 +0100 |
---|---|---|
committer | Sean McGivern <sean@gitlab.com> | 2017-07-07 12:42:38 +0100 |
commit | 38fd773bd3bb7ff479ca3d607da6966139e262e3 (patch) | |
tree | d866d1f88f52388b554699b2e19c832c9fe284bd | |
parent | de2d5ce685877249434ba412b5839910bc703882 (diff) | |
download | gitlab-ce-fix-sha-attribute-no-table.tar.gz |
Fix ShaAttribute concern when there is no tablefix-sha-attribute-no-table
When this is added to a new model, it would fail before the migrations were run
- including when trying to run migrations in production mode!
-rw-r--r-- | app/models/concerns/sha_attribute.rb | 2 | ||||
-rw-r--r-- | spec/models/concerns/sha_attribute_spec.rb | 31 |
2 files changed, 27 insertions, 6 deletions
diff --git a/app/models/concerns/sha_attribute.rb b/app/models/concerns/sha_attribute.rb index c28974a3cdf..67ecf470f7e 100644 --- a/app/models/concerns/sha_attribute.rb +++ b/app/models/concerns/sha_attribute.rb @@ -3,6 +3,8 @@ module ShaAttribute module ClassMethods def sha_attribute(name) + return unless table_exists? + column = columns.find { |c| c.name == name.to_s } # In case the table doesn't exist we won't be able to find the column, diff --git a/spec/models/concerns/sha_attribute_spec.rb b/spec/models/concerns/sha_attribute_spec.rb index 9e37c2b20c4..610793ee557 100644 --- a/spec/models/concerns/sha_attribute_spec.rb +++ b/spec/models/concerns/sha_attribute_spec.rb @@ -13,15 +13,34 @@ describe ShaAttribute do end describe '#sha_attribute' do - it 'defines a SHA attribute for a binary column' do - expect(model).to receive(:attribute) - .with(:sha1, an_instance_of(Gitlab::Database::ShaAttribute)) + context' when the table exists' do + before do + allow(model).to receive(:table_exists?).and_return(true) + end - model.sha_attribute(:sha1) + it 'defines a SHA attribute for a binary column' do + expect(model).to receive(:attribute) + .with(:sha1, an_instance_of(Gitlab::Database::ShaAttribute)) + + model.sha_attribute(:sha1) + end + + it 'raises ArgumentError when the column type is not :binary' do + expect { model.sha_attribute(:name) }.to raise_error(ArgumentError) + end end - it 'raises ArgumentError when the column type is not :binary' do - expect { model.sha_attribute(:name) }.to raise_error(ArgumentError) + context' when the table does not exist' do + before do + allow(model).to receive(:table_exists?).and_return(false) + end + + it 'does nothing' do + expect(model).not_to receive(:columns) + expect(model).not_to receive(:attribute) + + model.sha_attribute(:name) + end end end end |