summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArinde Eniola <eniolaarinde1@gmail.com>2016-04-29 10:44:31 +0100
committerArinde Eniola <eniolaarinde1@gmail.com>2016-04-29 10:44:31 +0100
commit3f33c621109430df389e58be3414e555e3a6b16d (patch)
tree75bbe8d003df32e634fff2a0f13a88fee993a07c
parenteab9be486d744ca3f9f6d989d7294e9e74ab1b93 (diff)
downloadgitlab-ce-fix_arrow_keys_not_working_in_top_search_box.tar.gz
make some changes to how the dropdown elements are clicked when enter key is pressedfix_arrow_keys_not_working_in_top_search_box
-rw-r--r--app/assets/javascripts/gl_dropdown.js.coffee13
1 files changed, 7 insertions, 6 deletions
diff --git a/app/assets/javascripts/gl_dropdown.js.coffee b/app/assets/javascripts/gl_dropdown.js.coffee
index d1c3bd76904..8651240a2ec 100644
--- a/app/assets/javascripts/gl_dropdown.js.coffee
+++ b/app/assets/javascripts/gl_dropdown.js.coffee
@@ -415,14 +415,14 @@ class GitLabDropdown
return selectedObject
- selectRowAtIndex: (index) ->
- selector = ".dropdown-content li:not(.divider):has('a'):eq(#{index}) a"
-
+ selectElement: (element) ->
if @dropdown.find(".dropdown-toggle-page").length
- selector = ".dropdown-page-one #{selector}"
+ link = $(element, "#{@dropdown} .dropdown-page-one").find('a').get()
+ link[0].click()
# simulate a click on the first link
- $(selector, @dropdown)[0].click() if $(selector, @dropdown)[0]
+ link = element.find('a').get()
+ link[0].click()
addArrowKeyEvent: ->
ARROW_KEY_CODES = [38, 40]
@@ -459,7 +459,8 @@ class GitLabDropdown
if currentKeyCode is 13
e.preventDefault()
e.stopImmediatePropagation()
- @selectRowAtIndex currentIndex
+ $listItems = $(selector, @dropdown).has('a')
+ @selectElement $listItems.eq(currentIndex)
removeArrayKeyEvent: ->
$('body').off 'keydown'