summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrancisco Javier López <fjlopez@gitlab.com>2018-07-27 12:34:05 -0400
committerFrancisco Javier López <fjlopez@gitlab.com>2018-07-27 12:34:05 -0400
commitf48561c19f057a26a904b731cc6856700aec90a9 (patch)
treec0b765cd017d9083fce3caba9230392460eb0ed3
parent34433b52f88064684cca31651e695236d73578b1 (diff)
downloadgitlab-ce-fj-37736-improve-performance-post-receive-minor-changes.tar.gz
Removing several dups because the param ends up in an async call (and therefore copied)fj-37736-improve-performance-post-receive-minor-changes
-rw-r--r--app/services/git_push_service.rb4
-rw-r--r--app/services/git_tag_push_service.rb4
2 files changed, 4 insertions, 4 deletions
diff --git a/app/services/git_push_service.rb b/app/services/git_push_service.rb
index d21ebf7da55..36eac3c88f0 100644
--- a/app/services/git_push_service.rb
+++ b/app/services/git_push_service.rb
@@ -152,8 +152,8 @@ class GitPushService < BaseService
Ci::CreatePipelineService.new(project, current_user, push_data).execute(:push)
SystemHookPushWorker.perform_async(push_data, :push_hooks)
- project.execute_hooks(push_data.dup, :push_hooks)
- project.execute_services(push_data.dup, :push_hooks)
+ project.execute_hooks(push_data, :push_hooks)
+ project.execute_services(push_data, :push_hooks)
if push_remove_branch?
AfterBranchDeleteService
diff --git a/app/services/git_tag_push_service.rb b/app/services/git_tag_push_service.rb
index 08b361089ab..505c9590824 100644
--- a/app/services/git_tag_push_service.rb
+++ b/app/services/git_tag_push_service.rb
@@ -9,8 +9,8 @@ class GitTagPushService < BaseService
Ci::CreatePipelineService.new(project, current_user, push_data).execute(:push)
SystemHooksService.new.execute_hooks(system_push_data, :tag_push_hooks)
- project.execute_hooks(push_data.dup, :tag_push_hooks)
- project.execute_services(push_data.dup, :tag_push_hooks)
+ project.execute_hooks(push_data, :tag_push_hooks)
+ project.execute_services(push_data, :tag_push_hooks)
ProjectCacheWorker.perform_async(project.id, [], [:commit_count, :repository_size])