diff options
author | Rémy Coutable <remy@rymai.me> | 2018-02-22 12:57:56 +0100 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-02-22 15:35:31 +0100 |
commit | 8a25a4f2eba98310b51e476adca48d667d2ce03e (patch) | |
tree | e895f4d00e706e2c18033cb64848cc46def6c9f2 | |
parent | 700e2a165bdfd7906f6f4bad5495c890f814f277 (diff) | |
download | gitlab-ce-get-rid-of-hardcoded-path-or-names-in-factories.tar.gz |
Get rid of hard-coded user/project/group names that could clash with DB sequencesget-rid-of-hardcoded-path-or-names-in-factories
Signed-off-by: Rémy Coutable <remy@rymai.me>
-rw-r--r-- | spec/features/projects_spec.rb | 8 | ||||
-rw-r--r-- | spec/requests/openid_connect_spec.rb | 12 |
2 files changed, 10 insertions, 10 deletions
diff --git a/spec/features/projects_spec.rb b/spec/features/projects_spec.rb index b66a7dea598..86a41e91c45 100644 --- a/spec/features/projects_spec.rb +++ b/spec/features/projects_spec.rb @@ -128,8 +128,8 @@ feature 'Project' do end describe 'removal', :js do - let(:user) { create(:user, username: 'test', name: 'test') } - let(:project) { create(:project, namespace: user.namespace, name: 'project1') } + let(:user) { create(:user) } + let(:project) { create(:project, namespace: user.namespace) } before do sign_in(user) @@ -138,8 +138,8 @@ feature 'Project' do end it 'removes a project' do - expect { remove_with_confirm('Remove project', project.path) }.to change {Project.count}.by(-1) - expect(page).to have_content "Project 'test / project1' is in the process of being deleted." + expect { remove_with_confirm('Remove project', project.path) }.to change { Project.count }.by(-1) + expect(page).to have_content "Project '#{user.name} / #{project.name}' is in the process of being deleted." expect(Project.all.count).to be_zero expect(project.issues).to be_empty expect(project.merge_requests).to be_empty diff --git a/spec/requests/openid_connect_spec.rb b/spec/requests/openid_connect_spec.rb index de829011e58..6bed8e812c0 100644 --- a/spec/requests/openid_connect_spec.rb +++ b/spec/requests/openid_connect_spec.rb @@ -68,10 +68,10 @@ describe 'OpenID Connect requests' do let!(:public_email) { build :email, email: 'public@example.com' } let!(:private_email) { build :email, email: 'private@example.com' } - let!(:group1) { create :group, path: 'group1' } - let!(:group2) { create :group, path: 'group2' } - let!(:group3) { create :group, path: 'group3', parent: group2 } - let!(:group4) { create :group, path: 'group4', parent: group3 } + let!(:group1) { create :group } + let!(:group2) { create :group } + let!(:group3) { create :group, parent: group2 } + let!(:group4) { create :group, parent: group3 } before do group1.add_user(user, GroupMember::OWNER) @@ -93,8 +93,8 @@ describe 'OpenID Connect requests' do 'groups' => anything })) - expected_groups = %w[group1 group2/group3] - expected_groups << 'group2/group3/group4' if Group.supports_nested_groups? + expected_groups = [group1.full_path, group3.full_path] + expected_groups << group4.full_path if Group.supports_nested_groups? expect(json_response['groups']).to match_array(expected_groups) end end |