summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouwe Maan <douwe@gitlab.com>2015-10-18 14:05:27 +0200
committerDouwe Maan <douwe@gitlab.com>2015-10-18 14:05:27 +0200
commitcc2b05adf80f55c9f0fe4b453f9f45e2b402c006 (patch)
tree81f68d195370a0fda5eee9e2487daf3669d2a8e3
parent38785046f7ec7d834e22add66e4be88f6e985355 (diff)
downloadgitlab-ce-hash-block-return.tar.gz
Fix bug where a push would only create cross references from the first commit.hash-block-return
-rw-r--r--app/services/git_push_service.rb2
-rw-r--r--lib/gitlab/reference_extractor.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/app/services/git_push_service.rb b/app/services/git_push_service.rb
index e54044365b9..3de7bb9dcaa 100644
--- a/app/services/git_push_service.rb
+++ b/app/services/git_push_service.rb
@@ -79,7 +79,7 @@ class GitPushService
authors = Hash.new do |hash, commit|
email = commit.author_email
- return hash[email] if hash.has_key?(email)
+ next hash[email] if hash.has_key?(email)
hash[email] = commit_user(commit)
end
diff --git a/lib/gitlab/reference_extractor.rb b/lib/gitlab/reference_extractor.rb
index 333bd059055..da8df8a3025 100644
--- a/lib/gitlab/reference_extractor.rb
+++ b/lib/gitlab/reference_extractor.rb
@@ -27,7 +27,7 @@ module Gitlab
def references
@references ||= Hash.new do |references, type|
type = type.to_sym
- return references[type] if references.has_key?(type)
+ next references[type] if references.has_key?(type)
references[type] = pipeline_result(type)
end