diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-04-10 12:04:30 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-04-10 12:06:07 -0700 |
| commit | b397ad8a6909ca21631dae5aae5e4a3373b5f2aa (patch) | |
| tree | 50c456d4f63cb6ee10880f2fdb0075297b2f0c55 | |
| parent | ddab30ad3561c6834fd779458ce89084c8a95ca5 (diff) | |
| download | gitlab-ce-b397ad8a6909ca21631dae5aae5e4a3373b5f2aa.tar.gz | |
Disable method instrumentation for diffs
When there a large number of discussions on diffs, the instrumentation
has a significant impact on performance since it's often run in a tight
loop for line position calculation etc. We should disable this since
there are other ways to benchmark performance.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52898
| -rw-r--r-- | changelogs/unreleased/sh-disable-diff-instrumentation.yml | 5 | ||||
| -rw-r--r-- | config/initializers/zz_metrics.rb | 1 |
2 files changed, 5 insertions, 1 deletions
diff --git a/changelogs/unreleased/sh-disable-diff-instrumentation.yml b/changelogs/unreleased/sh-disable-diff-instrumentation.yml new file mode 100644 index 00000000000..55f4c2a8510 --- /dev/null +++ b/changelogs/unreleased/sh-disable-diff-instrumentation.yml @@ -0,0 +1,5 @@ +--- +title: Disable method instrumentation for diffs +merge_request: 27235 +author: +type: performance diff --git a/config/initializers/zz_metrics.rb b/config/initializers/zz_metrics.rb index 151cad3ef9a..5aa6f73c5c5 100644 --- a/config/initializers/zz_metrics.rb +++ b/config/initializers/zz_metrics.rb @@ -30,7 +30,6 @@ def instrument_classes(instrumentation) # are included. %w(app services [^concerns]**) => %w(app services), %w(lib gitlab conflicts) => ['lib'], - %w(lib gitlab diff) => ['lib'], %w(lib gitlab email message) => ['lib'], %w(lib gitlab checks) => ['lib'] } |