diff options
author | Phil Hughes <me@iamphill.com> | 2018-07-25 09:24:38 +0100 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2018-07-25 09:24:38 +0100 |
commit | c3713fadeb5db56217027ac3cee9002cda0d1002 (patch) | |
tree | a7688dbc269e43f63564e89028b33f54c3fc2ccd | |
parent | 20116d57b77e276801eef17de8de854dd0f3b4aa (diff) | |
download | gitlab-ce-ide-codesandbox-poc.tar.gz |
improved checking to quickly return falseide-codesandbox-poc
-rw-r--r-- | app/assets/javascripts/ide/components/preview/clientside.vue | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/app/assets/javascripts/ide/components/preview/clientside.vue b/app/assets/javascripts/ide/components/preview/clientside.vue index bcc07c848ab..cd17c5d88ec 100644 --- a/app/assets/javascripts/ide/components/preview/clientside.vue +++ b/app/assets/javascripts/ide/components/preview/clientside.vue @@ -34,11 +34,11 @@ export default { }, {}); }, validProject() { - if (this.packageJson.raw === '') return false; + if (!this.packageJson.raw) return false; const parsedPackage = JSON.parse(this.packageJson.raw); - return parsedPackage ? parsedPackage.browser : false; + return parsedPackage.browser; }, showPreview() { return this.validProject && !this.loading; |