summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhil Hughes <me@iamphill.com>2018-05-22 15:16:10 +0100
committerPhil Hughes <me@iamphill.com>2018-05-22 15:16:10 +0100
commita7ea0e6bfb1fa11c8607281815a7bb6d70f89c25 (patch)
tree94d2dc2061ca3315b41dbdee28bdff39145c9e06
parentca6e2a4566dd1210c8d9cf51aeba97cf15b937e8 (diff)
downloadgitlab-ce-ide-file-finder-improve-order.tar.gz
changed what bit of code stops the callbackide-file-finder-improve-order
-rw-r--r--app/assets/javascripts/ide/components/ide.vue9
-rw-r--r--spec/javascripts/ide/components/ide_spec.js6
2 files changed, 11 insertions, 4 deletions
diff --git a/app/assets/javascripts/ide/components/ide.vue b/app/assets/javascripts/ide/components/ide.vue
index 816721958d6..1ec69adce09 100644
--- a/app/assets/javascripts/ide/components/ide.vue
+++ b/app/assets/javascripts/ide/components/ide.vue
@@ -44,9 +44,7 @@ export default {
e.preventDefault();
}
- if (!e.target.classList.contains('inputarea')) {
- this.toggleFileFinder(!this.fileFindVisible);
- }
+ this.toggleFileFinder(!this.fileFindVisible);
});
Mousetrap.stopCallback = (e, el, combo) => this.mousetrapStopCallback(e, el, combo);
@@ -54,7 +52,10 @@ export default {
methods: {
...mapActions(['toggleFileFinder']),
mousetrapStopCallback(e, el, combo) {
- if (combo === 't' && el.classList.contains('dropdown-input-field')) {
+ if (
+ (combo === 't' && el.classList.contains('dropdown-input-field')) ||
+ el.classList.contains('inputarea')
+ ) {
return true;
} else if (combo === 'command+p' || combo === 'ctrl+p') {
return false;
diff --git a/spec/javascripts/ide/components/ide_spec.js b/spec/javascripts/ide/components/ide_spec.js
index 6f580e1f7af..045a60e56a0 100644
--- a/spec/javascripts/ide/components/ide_spec.js
+++ b/spec/javascripts/ide/components/ide_spec.js
@@ -107,5 +107,11 @@ describe('ide component', () => {
vm.mousetrapStopCallback(null, vm.$el.querySelector('.dropdown-input-field'), 't'),
).toBe(true);
});
+
+ it('stops callback in monaco editor', () => {
+ setFixtures('<div class="inputarea"></div>');
+
+ expect(vm.mousetrapStopCallback(null, document.querySelector('.inputarea'), 't')).toBe(true);
+ });
});
});