summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDylan Griffith <dyl.griffith@gmail.com>2018-05-27 13:43:05 +0200
committerDylan Griffith <dyl.griffith@gmail.com>2018-05-31 10:56:41 +0200
commitd9251f2ea047d359d1d7d4799d1ba84da5896f64 (patch)
tree40c97f2bfbad7e0bd564df4fd9be70fa2c89b52e
parentbbd4cd118fc07df25c852058927c61ce582f19f9 (diff)
downloadgitlab-ce-d9251f2ea047d359d1d7d4799d1ba84da5896f64.tar.gz
Fix specs api/runners_spec.rb, api/v3/runners_spec.rb update_build_queue_service_spec.rb
-rw-r--r--spec/requests/api/runners_spec.rb2
-rw-r--r--spec/services/ci/update_build_queue_service_spec.rb3
2 files changed, 4 insertions, 1 deletions
diff --git a/spec/requests/api/runners_spec.rb b/spec/requests/api/runners_spec.rb
index 41cd93ac672..4dfc3b8cfc4 100644
--- a/spec/requests/api/runners_spec.rb
+++ b/spec/requests/api/runners_spec.rb
@@ -13,7 +13,7 @@ describe API::Runners do
let!(:shared_runner) { create(:ci_runner, :instance, description: 'Shared runner') }
let!(:project_runner) { create(:ci_runner, :project, description: 'Project runner', projects: [project]) }
- let!(:two_projects_runner) { create(:ci_runner, :project, description: 'Two projects runner', projects: [project, project2])
+ let!(:two_projects_runner) { create(:ci_runner, :project, description: 'Two projects runner', projects: [project, project2]) }
let!(:group_runner) { create(:ci_runner, :group, description: 'Group runner', groups: [group]) }
before do
diff --git a/spec/services/ci/update_build_queue_service_spec.rb b/spec/services/ci/update_build_queue_service_spec.rb
index e4b92956e48..ca0c6be5da6 100644
--- a/spec/services/ci/update_build_queue_service_spec.rb
+++ b/spec/services/ci/update_build_queue_service_spec.rb
@@ -15,6 +15,9 @@ describe Ci::UpdateBuildQueueService do
end
context 'when there is no runner that can pick build' do
+ let(:another_project) { create(:project) }
+ let(:runner) { create(:ci_runner, :project, projects: [another_project]) }
+
it 'does not tick runner queue value' do
expect { subject.execute(build) }.not_to change { runner.ensure_runner_queue_value }
end