diff options
| author | Stan Hu <stanhu@gmail.com> | 2016-08-16 07:17:41 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2016-08-16 07:17:41 -0700 |
| commit | a787b92f18bde0bac40c2d10b16dab3d5f6e2107 (patch) | |
| tree | 417c3908ceee1939c8e700f42ea35f8d061e2014 | |
| parent | f18f513dcb5ec9619ed44b041bf05e1d426edad2 (diff) | |
| download | gitlab-ce-improve-mr-diff-notes-spec.tar.gz | |
Prefer `find(:xpath, ...)` to `expect(...).to have_xpath`improve-mr-diff-notes-spec
| -rw-r--r-- | spec/features/merge_requests/diff_notes_spec.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/features/merge_requests/diff_notes_spec.rb b/spec/features/merge_requests/diff_notes_spec.rb index 78760e4afc5..daf629ee04d 100644 --- a/spec/features/merge_requests/diff_notes_spec.rb +++ b/spec/features/merge_requests/diff_notes_spec.rb @@ -141,7 +141,7 @@ feature 'Diff notes', js: true, feature: true do def comment_on_line(line_holder, line) line[:num].find(comment_button_class).trigger 'click' - expect(line_holder).to have_xpath notes_holder_input_xpath + line_holder.find(:xpath, notes_holder_input_xpath) notes_holder_input = line_holder.find(:xpath, notes_holder_input_xpath) expect(notes_holder_input[:class]).to include(notes_holder_input_class) |