summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValery Sizov <valery@gitlab.com>2017-03-07 16:58:17 +0200
committerValery Sizov <valery@gitlab.com>2017-03-16 15:55:33 +0200
commitd1a8116e80d22bb397242c61562d9c6934dc3aee (patch)
tree532682093289c9fcce5d83dd2641c61b841062fc
parentabb5f765c1e1affe0e132c86811e356e4a7008c9 (diff)
downloadgitlab-ce-improve_orderable_issues.tar.gz
Don't update issues relative position on view anymore[ci skip]improve_orderable_issues
-rw-r--r--app/controllers/projects/boards/issues_controller.rb7
-rw-r--r--app/services/issues/create_service.rb1
2 files changed, 0 insertions, 8 deletions
diff --git a/app/controllers/projects/boards/issues_controller.rb b/app/controllers/projects/boards/issues_controller.rb
index 28c9646910d..68437f5729f 100644
--- a/app/controllers/projects/boards/issues_controller.rb
+++ b/app/controllers/projects/boards/issues_controller.rb
@@ -8,7 +8,6 @@ module Projects
def index
issues = ::Boards::Issues::ListService.new(project, current_user, filter_params).execute
issues = issues.page(params[:page]).per(params[:per] || 20)
- make_sure_position_is_set(issues)
render json: {
issues: serialize_as_json(issues),
@@ -39,12 +38,6 @@ module Projects
private
- def make_sure_position_is_set(issues)
- issues.each do |issue|
- issue.move_to_end && issue.save unless issue.relative_position
- end
- end
-
def issue
@issue ||=
IssuesFinder.new(current_user, project_id: project.id)
diff --git a/app/services/issues/create_service.rb b/app/services/issues/create_service.rb
index 3cf4b82b9f2..540ee05291b 100644
--- a/app/services/issues/create_service.rb
+++ b/app/services/issues/create_service.rb
@@ -14,7 +14,6 @@ module Issues
def before_create(issue)
spam_check(issue, current_user)
- issue.move_to_end
end
def after_create(issuable)