summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBryce Johnson <bryce@gitlab.com>2017-06-13 11:40:22 -0400
committerBryce Johnson <bryce@gitlab.com>2017-06-13 11:40:22 -0400
commitb8390d95f1f18c683e7d547d8686ebde59ee4f88 (patch)
treedb0ea67cf7e3b67ea4459056c72eec9048436b14
parentdf01bce4021e1734ab374bf2d4b895e361b259f4 (diff)
downloadgitlab-ce-inject-add-diff-note.tar.gz
Remove dependency on Jquery in files_comment_button.inject-add-diff-note
-rw-r--r--app/assets/javascripts/files_comment_button.js24
1 files changed, 11 insertions, 13 deletions
diff --git a/app/assets/javascripts/files_comment_button.js b/app/assets/javascripts/files_comment_button.js
index 1d91b59ac48..9ff1df4f0d8 100644
--- a/app/assets/javascripts/files_comment_button.js
+++ b/app/assets/javascripts/files_comment_button.js
@@ -25,38 +25,36 @@ export default {
},
showButton(e) {
- const $currentTarget = $(e.currentTarget);
- const buttonParentElement = this.getButtonParent($currentTarget);
+ const buttonParentElement = this.getButtonParent(e.currentTarget);
if (!this.validateButtonParent(buttonParentElement)) return;
- buttonParentElement.addClass('is-over')
- .nextUntil(`.${LINE_CONTENT_CLASS}`).addClass('is-over');
+ buttonParentElement.classList.add('is-over');
+ buttonParentElement.nextElementSibling.classList.add('is-over');
},
hideButton(e) {
- const $currentTarget = $(e.currentTarget);
- const buttonParentElement = this.getButtonParent($currentTarget);
+ const buttonParentElement = this.getButtonParent(e.currentTarget);
- buttonParentElement.removeClass('is-over')
- .nextUntil(`.${LINE_CONTENT_CLASS}`).removeClass('is-over');
+ buttonParentElement.classList.remove('is-over');
+ buttonParentElement.nextElementSibling.classList.remove('is-over');
},
getButtonParent(hoveredElement) {
if (!notes.isParallelView()) {
- if (hoveredElement.hasClass(OLD_LINE_CLASS)) {
+ if (hoveredElement.classList.contains(OLD_LINE_CLASS)) {
return hoveredElement;
}
- return hoveredElement.parent().find(`.${OLD_LINE_CLASS});
+ return hoveredElement.parentNode.querySelector(`.${OLD_LINE_CLASS}`);
} else {
- if (hoveredElement.hasClass(LINE_NUMBER_CLASS)) {
+ if (hoveredElement.classList.contains(LINE_NUMBER_CLASS)) {
return hoveredElement;
}
- return $(hoveredElement).prev(`.${LINE_NUMBER_CLASS}`);
+ return hoveredElement.previousElementSibling;
}
},
validateButtonParent(buttonParentElement) {
- return !buttonParentElement.hasClass(EMPTY_CELL_CLASS) && !buttonParentElement.hasClass(UNFOLDABLE_LINE_CLASS);
+ return !buttonParentElement.classList.contains(EMPTY_CELL_CLASS) && !buttonParentElement.classList.contains(UNFOLDABLE_LINE_CLASS);
},
};