summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAhmad Sherif <me@ahmadsherif.com>2018-02-05 20:22:46 +0100
committerAhmad Sherif <me@ahmadsherif.com>2018-02-05 20:22:46 +0100
commitaf0f69f336c2ec4e5c18a4454920d002ce5d1022 (patch)
treec80c59c0340b16f23b5879075e23b91dc6a9ef44
parent64d7ec0a9e3ffd6233ccfbe9100f8a9391c648e5 (diff)
downloadgitlab-ce-investigate/notes-n-plus-1.tar.gz
Release an OLD KRAKENinvestigate/notes-n-plus-1
-rw-r--r--app/services/notes/create_service.rb4
1 files changed, 1 insertions, 3 deletions
diff --git a/app/services/notes/create_service.rb b/app/services/notes/create_service.rb
index 9ea28733f5f..bb4728e15ca 100644
--- a/app/services/notes/create_service.rb
+++ b/app/services/notes/create_service.rb
@@ -6,9 +6,7 @@ module Notes
note = Notes::BuildService.new(project, current_user, params).execute
# n+1: https://gitlab.com/gitlab-org/gitlab-ce/issues/37440
- note_valid = Gitlab::GitalyClient.allow_n_plus_1_calls do
- note.valid?
- end
+ note_valid = note.valid?
return note unless note_valid