diff options
author | Felipe Artur <felipefac@gmail.com> | 2017-03-15 17:58:09 -0300 |
---|---|---|
committer | Felipe Artur <felipefac@gmail.com> | 2017-03-16 16:31:02 -0300 |
commit | 165acd5aa3f586ff7b048e2be9c4b79b2602a188 (patch) | |
tree | f17ccd373a11fd1416b84a9b59536397837e413d | |
parent | 47a4b6e82f744545b96df68dba6939d536a8123e (diff) | |
download | gitlab-ce-issue_27212.tar.gz |
Add closed_at field to issuesissue_27212
-rw-r--r-- | app/models/issue.rb | 8 | ||||
-rw-r--r-- | changelogs/unreleased/issue_27212.yml | 4 | ||||
-rw-r--r-- | db/migrate/20170315194013_add_closed_at_to_issues.rb | 7 | ||||
-rw-r--r-- | db/schema.rb | 3 | ||||
-rw-r--r-- | spec/models/issue_spec.rb | 24 |
5 files changed, 45 insertions, 1 deletions
diff --git a/app/models/issue.rb b/app/models/issue.rb index 1427fdc31a4..02f87728cc1 100644 --- a/app/models/issue.rb +++ b/app/models/issue.rb @@ -55,6 +55,14 @@ class Issue < ActiveRecord::Base state :opened state :reopened state :closed + + after_transition any => :closed do |issue| + issue.update(closed_at: Time.zone.now) + end + + after_transition closed: any do |issue| + issue.update(closed_at: nil) + end end def hook_attrs diff --git a/changelogs/unreleased/issue_27212.yml b/changelogs/unreleased/issue_27212.yml new file mode 100644 index 00000000000..7a7e04f7ca7 --- /dev/null +++ b/changelogs/unreleased/issue_27212.yml @@ -0,0 +1,4 @@ +--- +title: Add closed_at field to issues +merge_request: +author: diff --git a/db/migrate/20170315194013_add_closed_at_to_issues.rb b/db/migrate/20170315194013_add_closed_at_to_issues.rb new file mode 100644 index 00000000000..1326118cc8d --- /dev/null +++ b/db/migrate/20170315194013_add_closed_at_to_issues.rb @@ -0,0 +1,7 @@ +class AddClosedAtToIssues < ActiveRecord::Migration + DOWNTIME = false + + def change + add_column :issues, :closed_at, :datetime + end +end diff --git a/db/schema.rb b/db/schema.rb index 3bef910c1d6..d3f9a6514b3 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -11,7 +11,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 20170315174634) do +ActiveRecord::Schema.define(version: 20170315194013) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -531,6 +531,7 @@ ActiveRecord::Schema.define(version: 20170315174634) do t.text "description_html" t.integer "time_estimate" t.integer "relative_position" + t.datetime "closed_at" end add_index "issues", ["assignee_id"], name: "index_issues_on_assignee_id", using: :btree diff --git a/spec/models/issue_spec.rb b/spec/models/issue_spec.rb index 9ffcb88bafd..73977d031f9 100644 --- a/spec/models/issue_spec.rb +++ b/spec/models/issue_spec.rb @@ -37,6 +37,30 @@ describe Issue, models: true do end end + describe '#closed_at' do + after do + Timecop.return + end + + let!(:now) { Timecop.freeze(Time.now) } + + it 'sets closed_at to Time.now when issue is closed' do + issue = create(:issue, state: 'opened') + + issue.close + + expect(issue.closed_at).to eq(now) + end + + it 'sets closed_at to nil when issue is reopened' do + issue = create(:issue, state: 'closed') + + issue.reopen + + expect(issue.closed_at).to be_nil + end + end + describe '#to_reference' do let(:namespace) { build(:namespace, path: 'sample-namespace') } let(:project) { build(:empty_project, name: 'sample-project', namespace: namespace) } |