summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelipe Artur <felipefac@gmail.com>2017-07-07 19:21:00 -0300
committerFelipe Artur <felipefac@gmail.com>2017-07-07 19:21:00 -0300
commitb7860b30aa4cf9d6b40ef2766912b366d916a9c7 (patch)
tree705cff160eb6a651bbdcb9151116ff7bad7f83f8
parent1e81c4be5352c30e810ad5baf832666c61dc4f0f (diff)
downloadgitlab-ce-issue_34852.tar.gz
fix milestones finder failing specissue_34852
-rw-r--r--app/finders/milestones_finder.rb3
1 files changed, 2 insertions, 1 deletions
diff --git a/app/finders/milestones_finder.rb b/app/finders/milestones_finder.rb
index 23c42a5f662..0a5a0ea2f35 100644
--- a/app/finders/milestones_finder.rb
+++ b/app/finders/milestones_finder.rb
@@ -49,7 +49,8 @@ class MilestonesFinder
if params.has_key?(:order)
items.reorder(params[:order])
else
- items.reorder('due_date ASC')
+ order_statement = Gitlab::Database.nulls_last_order('due_date', 'ASC')
+ items.reorder(order_statement)
end
end
end