summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelipe Artur <felipefac@gmail.com>2018-07-05 17:48:53 -0300
committerFelipe Artur <felipefac@gmail.com>2018-07-05 17:48:53 -0300
commit4e52fa9335bd01f0a6b3e69111f4d398c56f66b3 (patch)
tree70b8b6db9420fb0f7e2c9409a763b6e992b748cf
parentf32c06ac0a9c1bdcd40be95272a1f12a4af5c2e6 (diff)
downloadgitlab-ce-issue_48886.tar.gz
Change paramter name to 'view_type'issue_48886
-rw-r--r--app/controllers/projects/merge_requests/diffs_controller.rb2
-rw-r--r--app/serializers/diff_file_entity.rb2
-rw-r--r--spec/serializers/diff_file_entity_spec.rb4
3 files changed, 4 insertions, 4 deletions
diff --git a/app/controllers/projects/merge_requests/diffs_controller.rb b/app/controllers/projects/merge_requests/diffs_controller.rb
index 6d0c00146d9..800addb8a7f 100644
--- a/app/controllers/projects/merge_requests/diffs_controller.rb
+++ b/app/controllers/projects/merge_requests/diffs_controller.rb
@@ -69,7 +69,7 @@ class Projects::MergeRequests::DiffsController < Projects::MergeRequests::Applic
def additional_attributes
{
- view: params[:view],
+ view_type: params[:view_type],
environment: @environment,
merge_request: @merge_request,
merge_request_diff: @merge_request_diff,
diff --git a/app/serializers/diff_file_entity.rb b/app/serializers/diff_file_entity.rb
index 6b695190569..10d020e05a5 100644
--- a/app/serializers/diff_file_entity.rb
+++ b/app/serializers/diff_file_entity.rb
@@ -159,7 +159,7 @@ class DiffFileEntity < Grape::Entity
strong_memoize(:view_type) do
types = ::Gitlab::Diff::File::VIEW_TYPES
- return options[:view] if types.include?(options[:view])
+ return options[:view_type] if types.include?(options[:view_type])
types.first
end
diff --git a/spec/serializers/diff_file_entity_spec.rb b/spec/serializers/diff_file_entity_spec.rb
index d1d44c67a7f..434a1569c79 100644
--- a/spec/serializers/diff_file_entity_spec.rb
+++ b/spec/serializers/diff_file_entity_spec.rb
@@ -41,14 +41,14 @@ describe DiffFileEntity do
end
context 'when view type is parallel' do
- let(:entity) { described_class.new(diff_file, request: {}, view: 'inline') }
+ let(:entity) { described_class.new(diff_file, request: {}, view_type: 'inline') }
it { is_expected.not_to include(:parallel_diff_lines) }
it { is_expected.to include(:highlighted_diff_lines) }
end
context 'when view type is inline' do
- let(:entity) { described_class.new(diff_file, request: {}, view: 'parallel') }
+ let(:entity) { described_class.new(diff_file, request: {}, view_type: 'parallel') }
it { is_expected.to include(:parallel_diff_lines) }
it { is_expected.not_to include(:highlighted_diff_lines) }