Use SQL to find the gap instead of iteratingjprovazn-fix-positioning

Also removes unnecessary methods causing extra queries

4 files changed, 91 insertions, 145 deletions

diff --git a/app/models/concerns/relative_positioning.rb b/app/models/concerns/relative_positioning.rb
index 5395db509b5..7d357e09c87 100644
--- a/app/models/concerns/relative_positioning.rb
+++ b/app/models/concerns/relative_positioning.rb
@@ -28,13 +28,6 @@ module RelativePositioning
   START_POSITION = Gitlab::Database::MAX_INT_VALUE / 2
   MAX_POSITION = Gitlab::Database::MAX_INT_VALUE
   IDEAL_DISTANCE = 500
-  MAX_SEQUENCE_LIMIT = 1000
-
-  class GapNotFound < StandardError
-    def message
-      'Could not find a gap in the sequence of relative positions.'
-    end
-  end
 
   class_methods do
     def move_nulls_to_end(objects)
@@ -132,7 +125,7 @@ module RelativePositioning
     pos_before = before.relative_position
     pos_after = before.next_relative_position
 
-    if before.shift_after?
+    if pos_after && (pos_after - pos_before) < 2
       before.move_sequence_after
     end
 
@@ -143,7 +136,7 @@ module RelativePositioning
     pos_after = after.relative_position
     pos_before = after.prev_relative_position
 
-    if after.shift_before?
+    if pos_before && (pos_after - pos_before) < 2
       after.move_sequence_before
     end
 
@@ -158,29 +151,77 @@ module RelativePositioning
     self.relative_position = self.class.position_between(min_relative_position || START_POSITION, MIN_POSITION)
   end
 
-  # Indicates if there is an item that should be shifted to free the place
-  def shift_after?
-    next_pos = next_relative_position
-    next_pos && (next_pos - relative_position) == 1
+  # Moves the sequence before the current item to the middle of the next gap
+  # For example, we have 5 11 12 13 14 15 and the current item is 15
+  # This moves the sequence 11 12 13 14 to 8 9 10 11
+  def move_sequence_before
+    next_gap = find_next_gap_before
+    delta = optimum_delta_for_gap(next_gap)
+
+    move_sequence(next_gap['start'], relative_position, -delta)
   end
 
-  # Indicates if there is an item that should be shifted to free the place
-  def shift_before?
-    prev_pos = prev_relative_position
-    prev_pos && (relative_position - prev_pos) == 1
+  # Moves the sequence after the current item to the middle of the next gap
+  # For example, we have 11 12 13 14 15 21 and the current item is 11
+  # This moves the sequence 12 13 14 15 to 15 16 17 18
+  def move_sequence_after
+    next_gap = find_next_gap_after
+    delta = optimum_delta_for_gap(next_gap)
+
+    move_sequence(relative_position, next_gap['start'], delta)
   end
 
-  def move_sequence_before
-    items_to_move = scoped_items_batch.where('relative_position <= ?', relative_position).order('relative_position DESC')
-    move_nearest_sequence(items_to_move, MIN_POSITION)
+  private
+
+  # Supposing that we have a sequence of items: 1 5 11 12 13 and the current item is 13
+  # This would return: `{'start': 11, 'end': 5}`
+  def find_next_gap_before
+    items_with_next_pos = scoped_items
+                            .select('relative_position AS pos, LEAD(relative_position) OVER (ORDER BY relative_position DESC) AS next_pos')
+                            .where('relative_position <= ?', relative_position)
+                            .order(relative_position: :desc)
+
+    find_next_gap(items_with_next_pos).tap do |gap|
+      gap['end'] ||= MIN_POSITION
+    end
   end
 
-  def move_sequence_after
-    items_to_move = scoped_items_batch.where('relative_position >= ?', relative_position).order(:relative_position)
-    move_nearest_sequence(items_to_move, MAX_POSITION)
+  # Supposing that we have a sequence of items: 13 14 15 20 24 and the current item is 13
+  # This would return: `{'start': 15, 'end': 20}`
+  def find_next_gap_after
+    items_with_next_pos = scoped_items
+                            .select('relative_position AS pos, LEAD(relative_position) OVER (ORDER BY relative_position ASC) AS next_pos')
+                            .where('relative_position >= ?', relative_position)
+                            .order(:relative_position)
+
+    find_next_gap(items_with_next_pos).tap do |gap|
+      gap['end'] ||= MAX_POSITION
+    end
   end
 
-  private
+  def find_next_gap(items_with_next_pos)
+    query = self.class.select('pos AS start, next_pos AS end')
+                      .from(items_with_next_pos, :items_with_next_pos)
+                      .where('ABS(pos - next_pos) > 1 OR next_pos IS NULL')
+                      .limit(1)
+
+    results = ActiveRecord::Base.connection.execute(query.to_sql)
+    results.first.to_h
+  end
+
+  def optimum_delta_for_gap(gap)
+    delta = ((gap['start'] - gap['end']) / 2.0).abs.ceil
+    delta = IDEAL_DISTANCE if delta > IDEAL_DISTANCE
+
+    delta
+  end
+
+  def move_sequence(start_pos, end_pos, delta)
+    scoped_items
+      .where.not(id: self.id)
+      .where('relative_position BETWEEN ? AND ?', start_pos, end_pos)
+      .update_all("relative_position = relative_position + #{delta}")
+  end
 
   def calculate_relative_position(calculation)
     # When calculating across projects, this is much more efficient than
@@ -202,69 +243,4 @@ module RelativePositioning
   def scoped_items
     self.class.relative_positioning_query_base(self)
   end
-
-  def scoped_items_batch
-    scoped_items.limit(MAX_SEQUENCE_LIMIT).select(:id, :relative_position).where.not(id: self.id)
-  end
-
-  # Supposing that we have a sequence of positions: 5 11 12 13 14 15,
-  # and we want to move another item between 14 and 15, then
-  # we shift previous positions at least by one item, but ideally to the middle
-  # of the nearest gap. In this case gap is between 5 and 11 so
-  # this would move 11 12 13 14 to 8 9 10 11.
-  def move_nearest_sequence(items, end_position)
-    gap_idx, gap_size = find_gap_in_sequence(items)
-
-    # If we didn't find a gap in the sequence, it's still possible that there
-    # are some free positions before the first item
-    if gap_idx.nil? && !items.empty? && items.size < MAX_SEQUENCE_LIMIT &&
-        items.last.relative_position != end_position
-
-      gap_idx = items.size
-      gap_size = end_position - items.last.relative_position
-    end
-
-    # The chance that there is a sequence of 1000 positions w/o gap is really
-    # low, but it would be good to rebalance all positions in the scope instead
-    # of raising an exception:
-    # https://gitlab.com/gitlab-org/gitlab-ce/issues/64514#note_192657097
-    raise GapNotFound if gap_idx.nil?
-    # No shift is needed if gap is next to the item being moved
-    return true if gap_idx == 0
-
-    delta = max_delta_for_sequence(gap_size)
-    sequence_ids = items.first(gap_idx).map(&:id)
-    move_ids_by_delta(sequence_ids, delta)
-  end
-
-  def max_delta_for_sequence(gap_size)
-    delta = gap_size / 2
-
-    if delta.abs > IDEAL_DISTANCE
-      delta = delta < 0 ? -IDEAL_DISTANCE : IDEAL_DISTANCE
-    end
-
-    delta
-  end
-
-  def move_ids_by_delta(ids, delta)
-    self.class.where(id: ids).update_all("relative_position=relative_position+#{delta}")
-  end
-
-  def find_gap_in_sequence(items)
-    prev = relative_position
-    gap = nil
-
-    items.each_with_index do |rec, idx|
-      size = rec.relative_position - prev
-      if size.abs > 1
-        gap = [idx, size]
-        break
-      end
-
-      prev = rec.relative_position
-    end
-
-    gap
-  end
 end
diff --git a/db/migrate/20190802012622_reorder_issues_project_id_relative_position_index.rb b/db/migrate/20190802012622_reorder_issues_project_id_relative_position_index.rb
new file mode 100644
index 00000000000..12088dd763f
--- /dev/null
+++ b/db/migrate/20190802012622_reorder_issues_project_id_relative_position_index.rb
@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+class ReorderIssuesProjectIdRelativePositionIndex < ActiveRecord::Migration[5.2]
+  include Gitlab::Database::MigrationHelpers
+
+  DOWNTIME = false
+
+  disable_ddl_transaction!
+
+  OLD_INDEX_NAME = 'index_issues_on_project_id_and_state_and_rel_position_and_id'
+  NEW_INDEX_NAME = 'index_issues_on_project_id_and_rel_position_and_state_and_id'
+
+  def up
+    add_concurrent_index :issues, [:project_id, :relative_position, :state, :id], order: { id: :desc }, name: NEW_INDEX_NAME
+
+    remove_concurrent_index_by_name :issues, OLD_INDEX_NAME
+  end
+
+  def down
+    add_concurrent_index :issues, [:project_id, :state, :relative_position, :id], order: { id: :desc }, name: OLD_INDEX_NAME
+
+    remove_concurrent_index_by_name :issues, NEW_INDEX_NAME
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
index 709f9ce2541..843c519e4ac 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2019_07_31_084415) do
+ActiveRecord::Schema.define(version: 2019_08_02_012622) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "pg_trgm"
@@ -1715,7 +1715,7 @@ ActiveRecord::Schema.define(version: 2019_07_31_084415) do
     t.index ["project_id", "created_at", "id", "state"], name: "index_issues_on_project_id_and_created_at_and_id_and_state"
     t.index ["project_id", "due_date", "id", "state"], name: "idx_issues_on_project_id_and_due_date_and_id_and_state_partial", where: "(due_date IS NOT NULL)"
     t.index ["project_id", "iid"], name: "index_issues_on_project_id_and_iid", unique: true
-    t.index ["project_id", "state", "relative_position", "id"], name: "index_issues_on_project_id_and_state_and_rel_position_and_id", order: { id: :desc }
+    t.index ["project_id", "relative_position", "state", "id"], name: "index_issues_on_project_id_and_rel_position_and_state_and_id", order: { id: :desc }
     t.index ["project_id", "updated_at", "id", "state"], name: "index_issues_on_project_id_and_updated_at_and_id_and_state"
     t.index ["relative_position"], name: "index_issues_on_relative_position"
     t.index ["state"], name: "index_issues_on_state"
diff --git a/spec/support/shared_examples/relative_positioning_shared_examples.rb b/spec/support/shared_examples/relative_positioning_shared_examples.rb
index 417ef4f315b..9837ba806db 100644
--- a/spec/support/shared_examples/relative_positioning_shared_examples.rb
+++ b/spec/support/shared_examples/relative_positioning_shared_examples.rb
@@ -110,46 +110,6 @@ RSpec.shared_examples 'a class that supports relative positioning' do
     end
   end
 
-  describe '#shift_after?' do
-    before do
-      [item1, item2].each do |item1|
-        item1.move_to_end && item1.save
-      end
-    end
-
-    it 'returns true' do
-      item1.update(relative_position: item2.relative_position - 1)
-
-      expect(item1.shift_after?).to be_truthy
-    end
-
-    it 'returns false' do
-      item1.update(relative_position: item2.relative_position - 2)
-
-      expect(item1.shift_after?).to be_falsey
-    end
-  end
-
-  describe '#shift_before?' do
-    before do
-      [item1, item2].each do |item1|
-        item1.move_to_end && item1.save
-      end
-    end
-
-    it 'returns true' do
-      item1.update(relative_position: item2.relative_position + 1)
-
-      expect(item1.shift_before?).to be_truthy
-    end
-
-    it 'returns false' do
-      item1.update(relative_position: item2.relative_position + 2)
-
-      expect(item1.shift_before?).to be_falsey
-    end
-  end
-
   describe '#move_between' do
     before do
       [item1, item2].each do |item1|
@@ -297,13 +257,6 @@ RSpec.shared_examples 'a class that supports relative positioning' do
       positions = items.map { |item| item.reload.relative_position }
       expect(positions).to eq([50, 51, 102])
     end
-
-    it 'if raises an exception if gap is not found' do
-      stub_const('RelativePositioning::MAX_SEQUENCE_LIMIT', 2)
-      items = create_items_with_positions([100, 101, 102])
-
-      expect { items.last.move_sequence_before }.to raise_error(RelativePositioning::GapNotFound)
-    end
   end
 
   describe '#move_sequence_after' do
@@ -326,12 +279,5 @@ RSpec.shared_examples 'a class that supports relative positioning' do
       positions = items.map { |item| item.reload.relative_position }
       expect(positions).to eq([100, 601, 602])
     end
-
-    it 'if raises an exception if gap is not found' do
-      stub_const('RelativePositioning::MAX_SEQUENCE_LIMIT', 2)
-      items = create_items_with_positions([100, 101, 102])
-
-      expect { items.first.move_sequence_after }.to raise_error(RelativePositioning::GapNotFound)
-    end
   end
 end