summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Vosmaer <jacob@gitlab.com>2019-06-07 15:47:15 +0200
committerJacob Vosmaer <jacob@gitlab.com>2019-06-07 15:47:15 +0200
commitf204c22225217ecc5f865475141de7730c71cbf8 (patch)
tree46958f1ad6f0ed705d5e90f134976d3c72b5d123
parentf85375fc2250bf36f7c4a6d9815a0553b14a11d2 (diff)
downloadgitlab-ce-jv-doc-gitaly-dedup.tar.gz
Emphasize dangerjv-doc-gitaly-dedup
-rw-r--r--doc/administration/repository_storage_types.md6
-rw-r--r--doc/development/git_object_deduplication.md11
2 files changed, 12 insertions, 5 deletions
diff --git a/doc/administration/repository_storage_types.md b/doc/administration/repository_storage_types.md
index 4963d56a9df..38842693d73 100644
--- a/doc/administration/repository_storage_types.md
+++ b/doc/administration/repository_storage_types.md
@@ -106,8 +106,10 @@ enabled for individual projects by executing
be on hashed storage, should not be a fork itself, and hashed storage should be
enabled for all new projects.
-> Never run `git prune` or `git gc` in a pool repository. This can lead
-> to data loss in repositories that rely on that pool.
+DANGER: **Danger:**
+Do not run `git prune` or `git gc` in pool repositories! This can
+cause data loss in "real" repositories that depend on the pool in
+question.
### How to migrate to Hashed Storage
diff --git a/doc/development/git_object_deduplication.md b/doc/development/git_object_deduplication.md
index ac1daa3ada6..b512d7611d3 100644
--- a/doc/development/git_object_deduplication.md
+++ b/doc/development/git_object_deduplication.md
@@ -51,9 +51,14 @@ configuration. Objects in A that are not in B will remain in A. For this
to work, it is of course critical that **no objects ever get deleted from
B** because A might need them.
-> Do not run `git prune` or `git gc` in pool repositories! This can
-> cause data loss in "real" repositories that depend on the pool in
-> question.
+DANGER: **Danger:**
+Do not run `git prune` or `git gc` in pool repositories! This can
+cause data loss in "real" repositories that depend on the pool in
+question.
+
+The danger lies in `git prune`, and `git gc` calls `git prune`. The
+problem is that `git prune`, when running in a pool repository, cannot
+reliable decide if an object is no longer needed.
### Git alternates in GitLab: pool repositories