Add spec for assigning view param from cookiekkm/gitlab-ce-user-diff-view-pref-cookie

1 files changed, 19 insertions, 5 deletions

diff --git a/spec/controllers/projects/merge_requests_controller_spec.rb b/spec/controllers/projects/merge_requests_controller_spec.rb
index 183cfef3611..9450a389d81 100644
--- a/spec/controllers/projects/merge_requests_controller_spec.rb
+++ b/spec/controllers/projects/merge_requests_controller_spec.rb
@@ -200,15 +200,29 @@ describe Projects::MergeRequestsController do
   end
 
   describe 'GET diffs with view' do
+    def go(extra_params = {})
+      params = {
+        namespace_id: project.namespace.to_param,
+        project_id:   project.to_param,
+        id:           merge_request.iid
+      }
+
+      get :diffs, params.merge(extra_params)
+    end
+
     it 'saves the preferred diff view in a cookie' do
-      get :diffs,
-          namespace_id: project.namespace.to_param,
-          project_id: project.to_param,
-          id: merge_request.iid,
-          view: 'parallel'
+      go view: 'parallel'
 
       expect(response.cookies['diff_view']).to eq('parallel')
     end
+
+    it 'assigns :view param based on cookie' do
+      request.cookies['diff_view'] = 'parallel'
+
+      go
+
+      expect(controller.params[:view]).to eq 'parallel'
+    end
   end
 
   describe 'GET commits' do