summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormfluharty <mfluharty@gitlab.com>2019-04-08 21:16:52 -0600
committermfluharty <mfluharty@gitlab.com>2019-04-18 17:50:47 -0600
commit1798dcc1a6fc24e4fba8ed53d89cd86039a670f9 (patch)
tree317b4d0240256f1e2a0fcde627f93e186fe68146
parent9ec37d3dc1c1969be743a0c283242dc462a8f466 (diff)
downloadgitlab-ce-masked-variables-docs-update.tar.gz
Clarify masked variable message, add link to docsmasked-variables-docs-update
Update error message "This variable will not be masked" to "Cannot use Masked Variable with current value" Add link to masked variables section to error message
-rw-r--r--app/views/ci/variables/_variable_row.html.haml4
-rw-r--r--locale/gitlab.pot6
2 files changed, 6 insertions, 4 deletions
diff --git a/app/views/ci/variables/_variable_row.html.haml b/app/views/ci/variables/_variable_row.html.haml
index aecfdea10d9..12a8d9930b7 100644
--- a/app/views/ci/variables/_variable_row.html.haml
+++ b/app/views/ci/variables/_variable_row.html.haml
@@ -33,7 +33,9 @@
name: value_input_name,
placeholder: s_('CiVariables|Input variable value') }
= value
- %p.masking-validation-error.gl-field-error.hide= s_("CiVariables|This variable will not be masked")
+ %p.masking-validation-error.gl-field-error.hide
+ = s_("CiVariables|Cannot use Masked Variable with current value")
+ = link_to icon('question-circle'), help_page_path('ci/variables/README', anchor: 'masked-variables'), target: '_blank', rel: 'noopener noreferrer'
- unless only_key_value
.ci-variable-body-item.ci-variable-protected-item
.append-right-default
diff --git a/locale/gitlab.pot b/locale/gitlab.pot
index 54c40e48084..e25aff920e9 100644
--- a/locale/gitlab.pot
+++ b/locale/gitlab.pot
@@ -1785,6 +1785,9 @@ msgstr ""
msgid "CiStatus|running"
msgstr ""
+msgid "CiVariables|Cannot use Masked Variable with current value"
+msgstr ""
+
msgid "CiVariables|Input variable key"
msgstr ""
@@ -1794,9 +1797,6 @@ msgstr ""
msgid "CiVariables|Remove variable row"
msgstr ""
-msgid "CiVariables|This variable will not be masked"
-msgstr ""
-
msgid "CiVariable|* (All environments)"
msgstr ""