Update pipeline create chain Prometheus metricmetrics/gb/add-tmp-stage-creation-metrics

1 files changed, 3 insertions, 4 deletions

diff --git a/lib/gitlab/ci/pipeline/chain/create.rb b/lib/gitlab/ci/pipeline/chain/create.rb
index 42ae1650437..d19a2519803 100644
--- a/lib/gitlab/ci/pipeline/chain/create.rb
+++ b/lib/gitlab/ci/pipeline/chain/create.rb
@@ -18,9 +18,7 @@ module Gitlab
           rescue ActiveRecord::RecordInvalid => e
             error("Failed to persist the pipeline: #{e}")
           ensure
-            pipeline.builds.find_each do |build|
-              next if build.stage_id.present?
-
+            if pipeline.builds.where(stage_id: nil).any?
               invalid_builds_counter.increment(node: hostname)
             end
           end
@@ -33,7 +31,8 @@ module Gitlab
 
           def invalid_builds_counter
             @counter ||= Gitlab::Metrics
-              .counter(:invalid_builds_counter, 'Invalid builds counter')
+              .counter(:gitlab_ci_invalid_builds_total,
+                       'Invalid builds without stage assigned counter')
           end
 
           def hostname