summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Kozono <mkozono@gmail.com>2017-06-19 11:52:21 -0700
committerMichael Kozono <mkozono@gmail.com>2017-06-19 11:52:21 -0700
commit0f22c55a7a84b1a895c2284098f4b79d8bfab80a (patch)
tree91d2babc529367166c08aa8a4befbbed02979181
parentdbfab961bbd9f0d8dfa141f58c8742fe7589348f (diff)
downloadgitlab-ce-mk-refactor-user-namespace-association.tar.gz
-rw-r--r--spec/lib/gitlab/url_builder_spec.rb10
-rw-r--r--spec/presenters/ci/build_presenter_spec.rb4
-rw-r--r--spec/uploaders/file_uploader_spec.rb6
3 files changed, 10 insertions, 10 deletions
diff --git a/spec/lib/gitlab/url_builder_spec.rb b/spec/lib/gitlab/url_builder_spec.rb
index e8a37e8d77b..dce88f614df 100644
--- a/spec/lib/gitlab/url_builder_spec.rb
+++ b/spec/lib/gitlab/url_builder_spec.rb
@@ -4,7 +4,7 @@ describe Gitlab::UrlBuilder, lib: true do
describe '.build' do
context 'when passing a Commit' do
it 'returns a proper URL' do
- commit = build_stubbed(:commit)
+ commit = build(:commit)
url = described_class.build(commit)
@@ -14,7 +14,7 @@ describe Gitlab::UrlBuilder, lib: true do
context 'when passing an Issue' do
it 'returns a proper URL' do
- issue = build_stubbed(:issue, iid: 42)
+ issue = build(:issue, iid: 42)
url = described_class.build(issue)
@@ -24,7 +24,7 @@ describe Gitlab::UrlBuilder, lib: true do
context 'when passing a MergeRequest' do
it 'returns a proper URL' do
- merge_request = build_stubbed(:merge_request, iid: 42)
+ merge_request = build(:merge_request, iid: 42)
url = described_class.build(merge_request)
@@ -35,7 +35,7 @@ describe Gitlab::UrlBuilder, lib: true do
context 'when passing a Note' do
context 'on a Commit' do
it 'returns a proper URL' do
- note = build_stubbed(:note_on_commit)
+ note = create(:note_on_commit)
url = described_class.build(note)
@@ -45,7 +45,7 @@ describe Gitlab::UrlBuilder, lib: true do
context 'on a Commit Diff' do
it 'returns a proper URL' do
- note = build_stubbed(:diff_note_on_commit)
+ note = create(:diff_note_on_commit)
url = described_class.build(note)
diff --git a/spec/presenters/ci/build_presenter_spec.rb b/spec/presenters/ci/build_presenter_spec.rb
index 2190ab0e82e..6cd70f2ae95 100644
--- a/spec/presenters/ci/build_presenter_spec.rb
+++ b/spec/presenters/ci/build_presenter_spec.rb
@@ -85,7 +85,7 @@ describe Ci::BuildPresenter do
describe 'quack like a Ci::Build permission-wise' do
context 'user is not allowed' do
- let(:project) { build_stubbed(:empty_project, public_builds: false) }
+ let(:project) { create(:empty_project, public_builds: false) }
it 'returns false' do
expect(presenter.can?(nil, :read_build)).to be_falsy
@@ -93,7 +93,7 @@ describe Ci::BuildPresenter do
end
context 'user is allowed' do
- let(:project) { build_stubbed(:empty_project, :public) }
+ let(:project) { create(:empty_project, :public) }
it 'returns true' do
expect(presenter.can?(nil, :read_build)).to be_truthy
diff --git a/spec/uploaders/file_uploader_spec.rb b/spec/uploaders/file_uploader_spec.rb
index 47e9365e13d..457bf7d318f 100644
--- a/spec/uploaders/file_uploader_spec.rb
+++ b/spec/uploaders/file_uploader_spec.rb
@@ -1,11 +1,11 @@
require 'spec_helper'
describe FileUploader do
- let(:uploader) { described_class.new(build_stubbed(:empty_project)) }
+ let(:uploader) { described_class.new(build(:empty_project)) }
describe '.absolute_path' do
it 'returns the correct absolute path by building it dynamically' do
- project = build_stubbed(:project)
+ project = build(:project)
upload = double(model: project, path: 'secret/foo.jpg')
dynamic_segment = project.path_with_namespace
@@ -17,7 +17,7 @@ describe FileUploader do
describe "#store_dir" do
it "stores in the namespace path" do
- project = build_stubbed(:empty_project)
+ project = build(:empty_project)
uploader = described_class.new(project)
expect(uploader.store_dir).to include(project.path_with_namespace)