diff options
| author | Mark Lapierre <mlapierre@gitlab.com> | 2018-11-01 12:25:19 -0400 |
|---|---|---|
| committer | Mark Lapierre <mlapierre@gitlab.com> | 2018-11-01 12:37:15 -0400 |
| commit | d4c7ee54865be2e3671417c07e6ab51df45751ad (patch) | |
| tree | 1667f48c868535029eb71250d42cf960c0ff6b0d | |
| parent | 7f43b65fe54962a2fd3e4fd5d5413e4b1a0cf9c2 (diff) | |
| download | gitlab-ce-ml-fix-logging-qa.tar.gz | |
Don't log fabricate argsml-fix-logging-qa
Prevents logging of sensitive data
| -rw-r--r-- | qa/qa/factory/base.rb | 2 | ||||
| -rw-r--r-- | qa/spec/factory/base_spec.rb | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/qa/qa/factory/base.rb b/qa/qa/factory/base.rb index e28a00c545b..75438b77bf3 100644 --- a/qa/qa/factory/base.rb +++ b/qa/qa/factory/base.rb @@ -100,7 +100,7 @@ module QA msg = [prefix] msg << "Built a #{name}" msg << "as a dependency of #{parents.last}" if parents.any? - msg << "via #{method} with args #{args}" + msg << "via #{method}" yield.tap do msg << "in #{Time.now - start} seconds" diff --git a/qa/spec/factory/base_spec.rb b/qa/spec/factory/base_spec.rb index e9584a27d63..62bdf1dbfe1 100644 --- a/qa/spec/factory/base_spec.rb +++ b/qa/spec/factory/base_spec.rb @@ -82,7 +82,7 @@ describe QA::Factory::Base do expect(factory).to receive(:fabricate_via_api!).and_return(location) expect { subject.fabricate_via_api!(factory: factory, parents: []) } - .to output(/==> Built a MyFactory via api with args \[\] in [\d\w\.\-]+/) + .to output(/==> Built a MyFactory via api in [\d\w\.\-]+/) .to_stdout end end @@ -108,7 +108,7 @@ describe QA::Factory::Base do stub_env('QA_DEBUG', 'true') expect { subject.fabricate_via_browser_ui!('something', factory: factory, parents: []) } - .to output(/==> Built a MyFactory via browser_ui with args \["something"\] in [\d\w\.\-]+/) + .to output(/==> Built a MyFactory via browser_ui in [\d\w\.\-]+/) .to_stdout end end |