diff options
| author | Nathan Friend <nathan@gitlab.com> | 2019-08-28 16:13:07 -0300 |
|---|---|---|
| committer | Nathan Friend <nathan@gitlab.com> | 2019-08-28 16:13:07 -0300 |
| commit | ade2a5a6443461b98d90e34e53dc34142594667e (patch) | |
| tree | 796db2b9d40df606840e3add0d090778d8898697 | |
| parent | 148c5ccbb444f3c630e3b3cf4350bb4f74d6d2ab (diff) | |
| download | gitlab-ce-nfriend-add-anchor-tag-to-release-block.tar.gz | |
Add id to release blocknfriend-add-anchor-tag-to-release-block
This commit adds an id attribute to release blocks to allow them to be
targeted as anchor links.
| -rw-r--r-- | app/assets/javascripts/releases/components/release_block.vue | 2 | ||||
| -rw-r--r-- | spec/javascripts/releases/components/release_block_spec.js | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/app/assets/javascripts/releases/components/release_block.vue b/app/assets/javascripts/releases/components/release_block.vue index 7580c2d0ad0..88b6b4732b1 100644 --- a/app/assets/javascripts/releases/components/release_block.vue +++ b/app/assets/javascripts/releases/components/release_block.vue @@ -53,7 +53,7 @@ export default { }; </script> <template> - <div class="card"> + <div :id="release.tag_name" class="card"> <div class="card-body"> <h2 class="card-title mt-0"> {{ release.name }} diff --git a/spec/javascripts/releases/components/release_block_spec.js b/spec/javascripts/releases/components/release_block_spec.js index f761a18e326..fdf23f3f69d 100644 --- a/spec/javascripts/releases/components/release_block_spec.js +++ b/spec/javascripts/releases/components/release_block_spec.js @@ -88,6 +88,10 @@ describe('Release block', () => { vm.$destroy(); }); + it("renders the block with an id equal to the release's tag name", () => { + expect(vm.$el.id).toBe('18.04'); + }); + it('renders release name', () => { expect(vm.$el.textContent).toContain(release.name); }); |