summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNathan Friend <nathan@gitlab.com>2019-07-17 14:15:35 -0300
committerNathan Friend <nathan@gitlab.com>2019-07-17 14:15:35 -0300
commit0c0bc8dac6a1c41e0cc2e434416f72a92f8b3c12 (patch)
tree6bd4411a6fafdd7f38baca23ecbb3cf1c84e9216
parent2860cfaaff0a435792081b72a5f97de85e0d4f70 (diff)
downloadgitlab-ce-nfriend-prefer-undefined-over-null.tar.gz
Add recommendation to prefer `undefined` over `null`nfriend-prefer-undefined-over-null
-rw-r--r--doc/development/fe_guide/style_guide_js.md24
1 files changed, 24 insertions, 0 deletions
diff --git a/doc/development/fe_guide/style_guide_js.md b/doc/development/fe_guide/style_guide_js.md
index b50159c2b75..8f3848409e7 100644
--- a/doc/development/fe_guide/style_guide_js.md
+++ b/doc/development/fe_guide/style_guide_js.md
@@ -301,6 +301,30 @@ See [our current .eslintrc](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/
</button>
```
+#### Prefer `undefined` over `null`
+
+1. When you have the option of using either `null` or `undefined`, choose `undefined`:
+
+ ```javascript
+ // bad
+ props: {
+ selected: {
+ type: Object,
+ required: false,
+ default: null,
+ },
+ },
+
+ // good
+ props: {
+ selected: {
+ type: Object,
+ required: false,
+ default: undefined,
+ },
+ },
+ ```
+
### Vue.js
#### `eslint-vue-plugin`