diff options
| author | Nikolay Samokhvalov <gitlab@samokhvalov.com> | 2019-07-22 15:35:23 +0000 |
|---|---|---|
| committer | Nikolay Samokhvalov <gitlab@samokhvalov.com> | 2019-07-22 15:35:23 +0000 |
| commit | f624b8d066ee8a67aa16299dcffd91d20b98a57d (patch) | |
| tree | 7ba7b495056bf9c3d09d58b9981b1f803c0bc9ff | |
| parent | dc2267b37da17fa04f2545e36f86f5627c1604fd (diff) | |
| download | gitlab-ce-nik-db-migrations-prefer-atomic.tar.gz | |
Correction on DML+DDL in a single transactionnik-db-migrations-prefer-atomic
| -rw-r--r-- | doc/development/migration_style_guide.md | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/doc/development/migration_style_guide.md b/doc/development/migration_style_guide.md index 188032c3592..569c32c1f2a 100644 --- a/doc/development/migration_style_guide.md +++ b/doc/development/migration_style_guide.md @@ -99,13 +99,13 @@ anything because the target table is not yet used. Such an approach allows having fewer migration steps, which are atomic ("all or nothing"). -## No DDL and DML in a single transaction +## No schema changes and heavy operations in a single transaction However, a single-transaction migration (that one without `disable_ddl_transaction!`) involving schema changes must not include any -processing of significant (more than 1000 rows) data processing. If you need to -insert, update, or delete something, you must not do it inside a transaction -with DDL. +processing of significant (more than a few records rows) amounts of data. +If you need to insert, update, or delete something, you must not do it inside +a transaction with DDL. ## Multi-Threading |