diff options
author | Justin Boyson <jboyson@gitlab.com> | 2019-05-22 14:54:15 +0000 |
---|---|---|
committer | Justin Boyson <jboyson@gitlab.com> | 2019-05-22 14:54:15 +0000 |
commit | 23cf312538f7587751198945d5d6aa51fe2cd174 (patch) | |
tree | 76738ffe293470e9536e802ebe214ea30e041030 | |
parent | 98cdeed44c90580a0e51be7614e57dc65f87240d (diff) | |
download | gitlab-ce-patch-63.tar.gz |
Add line breaks to fix markdown formattingpatch-63
When code blocks do not have a line break between them and a bullet item the code block is not rendered properly.
-rw-r--r-- | doc/development/fe_guide/style_guide_js.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/doc/development/fe_guide/style_guide_js.md b/doc/development/fe_guide/style_guide_js.md index 060cd8baf7f..7e7df052284 100644 --- a/doc/development/fe_guide/style_guide_js.md +++ b/doc/development/fe_guide/style_guide_js.md @@ -95,6 +95,7 @@ See [our current .eslintrc](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/ #### Modules, Imports, and Exports 1. Use ES module syntax to import modules + ```javascript // bad const SomeClass = require('some_class'); @@ -168,6 +169,7 @@ See [our current .eslintrc](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/ Do not use them anymore and feel free to remove them when refactoring legacy code. 1. Avoid adding to the global namespace. + ```javascript // bad window.MyClass = class { /* ... */ }; @@ -177,6 +179,7 @@ See [our current .eslintrc](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/ ``` 1. Side effects are forbidden in any script which contains exports + ```javascript // bad export default class MyClass { /* ... */ } @@ -449,6 +452,7 @@ Please check this [rules][eslint-plugin-vue-rules] for more documentation. #### Props 1. Props should be declared as an object + ```javascript // bad props: ['foo'] |