summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhil Hughes <me@iamphill.com>2017-03-15 09:57:07 +0000
committerPhil Hughes <me@iamphill.com>2017-03-15 09:57:07 +0000
commit4a1d1eb9e74551f61ad04d211b42697e6dc52018 (patch)
tree1d37e346840806d97a204fa9eb966ab7837cc842
parent9226ce9e3090dcedcb5c9fa8595d75b5eb295726 (diff)
downloadgitlab-ce-pipeline-tooltips-overflow.tar.gz
Fixed pipeline action tooltips being cut offpipeline-tooltips-overflow
Changed the container for the tooltip to be the body so that the tooltip does not get cut off with the overflow area. This change affects both merge request pipelines table & the pipelines page Closes #29314
-rw-r--r--app/assets/javascripts/vue_pipelines_index/pipeline_actions.js4
-rw-r--r--changelogs/unreleased/pipeline-tooltips-overflow.yml4
2 files changed, 8 insertions, 0 deletions
diff --git a/app/assets/javascripts/vue_pipelines_index/pipeline_actions.js b/app/assets/javascripts/vue_pipelines_index/pipeline_actions.js
index 891f1f17fb3..583d6915a85 100644
--- a/app/assets/javascripts/vue_pipelines_index/pipeline_actions.js
+++ b/app/assets/javascripts/vue_pipelines_index/pipeline_actions.js
@@ -47,6 +47,7 @@ const playIconSvg = require('icons/_icon_play.svg');
data-toggle="dropdown"
title="Manual job"
data-placement="top"
+ data-container="body"
aria-label="Manual job">
<span v-html="playIconSvg" aria-hidden="true"></span>
<i class="fa fa-caret-down" aria-hidden="true"></i>
@@ -69,6 +70,7 @@ const playIconSvg = require('icons/_icon_play.svg');
class="dropdown-toggle btn btn-default build-artifacts has-tooltip js-pipeline-dropdown-download"
title="Artifacts"
data-placement="top"
+ data-container="body"
data-toggle="dropdown"
aria-label="Artifacts">
<i class="fa fa-download" aria-hidden="true"></i>
@@ -92,6 +94,7 @@ const playIconSvg = require('icons/_icon_play.svg');
rel="nofollow"
data-method="post"
data-placement="top"
+ data-container="body"
data-toggle="dropdown"
:href='pipeline.retry_path'
aria-label="Retry">
@@ -105,6 +108,7 @@ const playIconSvg = require('icons/_icon_play.svg');
rel="nofollow"
data-method="post"
data-placement="top"
+ data-container="body"
data-toggle="dropdown"
:href='pipeline.cancel_path'
aria-label="Cancel">
diff --git a/changelogs/unreleased/pipeline-tooltips-overflow.yml b/changelogs/unreleased/pipeline-tooltips-overflow.yml
new file mode 100644
index 00000000000..184da8049f3
--- /dev/null
+++ b/changelogs/unreleased/pipeline-tooltips-overflow.yml
@@ -0,0 +1,4 @@
+---
+title: Fixed pipeline actions tooltips overflowing
+merge_request:
+author: