diff options
| author | Rémy Coutable <remy@rymai.me> | 2019-04-10 17:28:23 +0200 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2019-04-17 10:49:02 +0200 |
| commit | 955136b56dd0551c18fc9917a3ea94790081d9df (patch) | |
| tree | 0d7e734505a8dcf8734a28cc9d4be465ff19b443 | |
| parent | b57e335829506f348c060c5b7ec4c79cbda792a7 (diff) | |
| download | gitlab-ce-qa-fix-review-app-ping.tar.gz | |
Don't fail the job if the Review App doesn't deploy properlyqa-fix-review-app-ping
It seems the deploy function causes the job to fail if it doesn't
succeed. That wasn't the intent as we want to curl the Review App after
the deploy finished (even if it failed) because sometimes the Review App
is just a bit long to be ready.
This change wraps the Review App deployment with "set +e"/"set -e" to
ensure that the job doesn't fail right away if the deploy fails.
Signed-off-by: Rémy Coutable <remy@rymai.me>
| -rwxr-xr-x | scripts/review_apps/review-apps.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/review_apps/review-apps.sh b/scripts/review_apps/review-apps.sh index 22e47ce2c0a..51cfd145ba8 100755 --- a/scripts/review_apps/review-apps.sh +++ b/scripts/review_apps/review-apps.sh @@ -109,7 +109,7 @@ function perform_review_app_deployment() { ensure_namespace install_tiller install_external_dns - time deploy || true + time deploy wait_for_review_app_to_be_accessible add_license } @@ -270,7 +270,7 @@ EOF echoinfo "Deploying with:" echoinfo "${HELM_CMD}" - eval $HELM_CMD + eval $HELM_CMD || true } function wait_for_review_app_to_be_accessible() { |