summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2018-11-29 17:23:38 +0100
committerRémy Coutable <remy@rymai.me>2018-12-05 15:46:38 +0100
commit5b3c19357a11f8fbcc4532da989c82c9dc443255 (patch)
tree001dcde9d58f1db5a36b09df0b8d6e0a7e08ce44
parent6520fa3ee063d8596dc0743e321308f4e24cb0b4 (diff)
downloadgitlab-ce-qa-raise-error-when-repository-command-fail.tar.gz
Improve a bit qa/qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rbqa-raise-error-when-repository-command-fail
Signed-off-by: Rémy Coutable <remy@rymai.me>
-rw-r--r--qa/qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rb12
1 files changed, 3 insertions, 9 deletions
diff --git a/qa/qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rb b/qa/qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rb
index 6ff7360c413..24edc4632a1 100644
--- a/qa/qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rb
@@ -10,6 +10,7 @@ module QA
project = Resource::Project.fabricate! do |project|
project.name = "squash-before-merge"
end
+ project.populate(:repository_http_location)
merge_request = Resource::MergeRequest.fabricate! do |merge_request|
merge_request.project = project
@@ -17,7 +18,7 @@ module QA
end
Resource::Repository::ProjectPush.fabricate! do |push|
- push.project = project
+ push.repository_http_uri = project.repository_http_location.uri
push.commit_message = 'to be squashed'
push.branch_name = merge_request.source_branch
push.new_branch = false
@@ -34,16 +35,9 @@ module QA
merge_request_page.mark_to_squash
merge_request_page.merge!
- merge_request.project.visit!
-
Git::Repository.perform do |repository|
- repository.uri = Page::Project::Show.act do
- choose_repository_clone_http
- repository_location.uri
- end
-
+ repository.uri = project.repository_http_location.uri
repository.use_default_credentials
-
repository.act { clone }
expect(repository.commits.size).to eq 3