diff options
author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2017-12-20 10:25:41 +0100 |
---|---|---|
committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2017-12-20 10:25:41 +0100 |
commit | 6ef86756254b246f025acd55140ac056efe746a6 (patch) | |
tree | 0d132476d2cde05449132fe40287ab426be83e33 | |
parent | 60c6ef6c072d77dcd4f999011906c231277f3cbe (diff) | |
download | gitlab-ce-qa/gb/add-dependencies-support-to-factories.tar.gz |
Rename QA factory alias to improve readabilityqa/gb/add-dependencies-support-to-factories
-rw-r--r-- | qa/qa/factory/base.rb | 4 | ||||
-rw-r--r-- | qa/spec/factory/base_spec.rb | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/qa/qa/factory/base.rb b/qa/qa/factory/base.rb index 7c03611dc0d..cfd16d209a0 100644 --- a/qa/qa/factory/base.rb +++ b/qa/qa/factory/base.rb @@ -21,8 +21,8 @@ module QA @dependencies ||= {} end - def self.dependency(factory, name: nil, &block) - (name || factory.name.split('::').last.downcase).tap do |name| + def self.dependency(factory, as: nil, &block) + (as || factory.name.split('::').last.downcase).tap do |name| class_eval { attr_accessor name } Dependency::Signature.new(factory, block).tap do |signature| diff --git a/qa/spec/factory/base_spec.rb b/qa/spec/factory/base_spec.rb index d3b7711f99b..ea10f06becd 100644 --- a/qa/spec/factory/base_spec.rb +++ b/qa/spec/factory/base_spec.rb @@ -67,7 +67,7 @@ describe QA::Factory::Base do context 'when using explicit resource name' do subject do Class.new(described_class) do - dependency Some::MyDependency, name: :otherdep do |factory| + dependency Some::MyDependency, as: :otherdep do |factory| factory.something! end end |